Problem: No unique indexes on transaction id and block height#2492
Merged
vrde merged 3 commits intobigchaindb:masterfrom Aug 29, 2018
Merged
Problem: No unique indexes on transaction id and block height#2492vrde merged 3 commits intobigchaindb:masterfrom
vrde merged 3 commits intobigchaindb:masterfrom
Conversation
Solution: Created unique indexes when setting up the collections
Solution: Assert if the indexes `transaction_id` and `height` are unique
vrde
approved these changes
Aug 29, 2018
Solution: Sign transactions before bulk store
Codecov Report
@@ Coverage Diff @@
## master #2492 +/- ##
=======================================
Coverage 91.08% 91.08%
=======================================
Files 41 41
Lines 2400 2400
=======================================
Hits 2186 2186
Misses 214 214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Add necessary unique indexes and corresponding tests.