Problem: BigchainDB has un-necessary code to initialize a replica set and check if MongoDB was started with replicaSet#2491
Conversation
Signed-off-by: Shahbaz Nazir <[email protected]>
Signed-off-by: Shahbaz Nazir <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2491 +/- ##
==========================================
+ Coverage 91.13% 91.48% +0.35%
==========================================
Files 41 41
Lines 2447 2397 -50
==========================================
- Hits 2230 2193 -37
+ Misses 217 204 -13 |
shahbazn
changed the title
vrde
left a comment
vrde
left a comment
There was a problem hiding this comment.
There are other places where replica, replica set and replicaset are used, for example in the docs and in the config. Please make sure those instances are removed as well.
|
@vrde Those instances of |
ttmc
left a comment
ttmc
left a comment
There was a problem hiding this comment.
Maybe add a one-line note in the docs page about the database.replicaset configuration setting to note that the replicaset must already exist and if it doesn't, BigchainDB won't create it.
Signed-off-by: Shahbaz Nazir <[email protected]>
5 participants
Solution: Remove un-necessary code. Deployment of MongoDB with or without replicaSet should be the responsibility of MongoDB admin which can and cannot be a BigchainDB node operator. As far as BigchainDB is concerned replicaset, if provided in bigchaindb configs, should be used to establish connection with MongoDB.
Resolves #2449