Problem: validating create+transfer might crash the system#2487
Merged
kansi merged 1 commit intobigchaindb:masterfrom Aug 29, 2018
Merged
Problem: validating create+transfer might crash the system#2487kansi merged 1 commit intobigchaindb:masterfrom
kansi merged 1 commit intobigchaindb:masterfrom
Conversation
Solution: if a TRANSFER transaction is validated after a CREATE transaction, the system crashes with `AttributeError: 'NoneType' object has no attribute 'txid'`. This happens because querying `get_spent` checks the attributes `txid` and `output` of `input.fulfills` for every transaction in the current buffer (`current_transactions`). For a CREATE, `input.fulfills` is None, so the check would fail. The solution is to check if `input.fulfills` is defined. If not, then the current transaction cannot spend any output, so we can safely skip it.
vrde
force-pushed
the
fix-validation-error
branch
from
14a8cb3 to
c1840d5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2487 +/- ##
=======================================
Coverage 91.08% 91.08%
=======================================
Files 41 41
Lines 2400 2400
=======================================
Hits 2186 2186
Misses 214 214 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: if a TRANSFER transaction is validated after a CREATE
transaction, the system crashes with
AttributeError: 'NoneType' object has no attribute 'txid'.This happens because querying
get_spentchecks the attributestxidand
outputofinput.fulfillsfor every transaction in the currentbuffer (
current_transactions). For a CREATE,input.fulfillsis None,so the check would fail.
The solution is to check if
input.fulfillsis defined. If not, thenthe current transaction cannot spend any output, so we can safely skip
it.