Problem: we have unused and outdated fixtures#2476
Merged
kansi merged 2 commits intobigchaindb:masterfrom Aug 27, 2018
Merged
Conversation
Solution: clean up fixtures and tests accordingly
Codecov Report
@@ Coverage Diff @@
## master #2476 +/- ##
==========================================
+ Coverage 90.14% 90.99% +0.84%
==========================================
Files 41 41
Lines 2365 2365
==========================================
+ Hits 2132 2152 +20
+ Misses 233 213 -20 |
16 tasks
kansi
reviewed
Aug 23, 2018
| @patch('bigchaindb.config_utils.autoconfigure') | ||
| @patch('bigchaindb.commands.bigchaindb.run_recover') | ||
| @patch('bigchaindb.start.start') | ||
| def test_recover_db_on_start(mock_autoconfigure, |
Contributor
There was a problem hiding this comment.
why was mock_autoconfigure removed?
Contributor
Author
There was a problem hiding this comment.
oh, that might have been a mistake. I see that the patch is still in. I need to check. If I removed it then because it was not needed, but I need to check again.
Contributor
Author
There was a problem hiding this comment.
ok, so I can confirm now, that it is not needed. I'll remove the patch in the next commit
Solution: remove Merlin keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: clean up fixtures and tests accordingly
#2381