Problem: websocket might be unresponsive#2413
Merged
shahbazn merged 1 commit intobigchaindb:masterfrom Jul 26, 2018
Merged
Conversation
Solution: It might be related on how aiohttp 2.x handles `send_str`. AFAIK the call `send_str` was not "fully async". In aiohttp 3.x they [changed it][1]: > send_str(), send_bytes(), send_json(), ping() and pong() are genuine async functions now. (bigchaindb#2475) So this patch adds support for aiohttp 3.x, and uses the `send_str` coroutine. [1]: https://github.com/aio-libs/aiohttp/blob/master/HISTORY.rst#deprecations-and-removals-1
shahbazn
approved these changes
Jul 26, 2018
Codecov Report
@@ Coverage Diff @@
## master #2413 +/- ##
=======================================
Coverage 86.86% 86.86%
=======================================
Files 38 38
Lines 2169 2169
=======================================
Hits 1884 1884
Misses 285 285 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: It might be related on how aiohttp 2.x handles
send_str.AFAIK the call
send_strwas not "fully async". In aiohttp 3.x theychanged it:
So this patch adds support for aiohttp 3.x, and uses the
send_strcoroutine.