Problem: validation runs redundant queries#2409
Merged
kansi merged 1 commit intobigchaindb:masterfrom Jul 25, 2018
Merged
Conversation
Solution: when a transaction is stored, the system splits it in three components, data, metadata, and the other fields of the transaction. When the system retrieves a transaction, it needs to make three different queries to reconstruct the original transaction. If a transaction does not exist, the system does three queries anyway, even if just one query is enough. This patch fixes this by doing the additional queries if and only if the transaction exists.
Codecov Report
@@ Coverage Diff @@
## master #2409 +/- ##
======================================
Coverage 86.9% 86.9%
======================================
Files 38 38
Lines 2169 2169
======================================
Hits 1885 1885
Misses 284 284 |
kansi
approved these changes
Jul 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: when a transaction is stored, the system splits it in three
components, data, metadata, and the other fields of the transaction.
When the system retrieves a transaction, it needs to make three
different queries to reconstruct the original transaction. If a
transaction does not exist, the system does three queries anyway, even
if just one query is enough. This patch fixes this by doing the
additional queries if and only if the transaction exists.