Problem: abruptly closed sockets still in memory#2408
Merged
shahbazn merged 1 commit intobigchaindb:masterfrom Jul 26, 2018
Merged
Problem: abruptly closed sockets still in memory#2408shahbazn merged 1 commit intobigchaindb:masterfrom
shahbazn merged 1 commit intobigchaindb:masterfrom
Conversation
Solution: Catch the proper exception and remove socket from memory.
Codecov Report
@@ Coverage Diff @@
## master #2408 +/- ##
==========================================
- Coverage 86.9% 86.79% -0.12%
==========================================
Files 38 38
Lines 2169 2173 +4
==========================================
+ Hits 1885 1886 +1
- Misses 284 287 +3 |
shahbazn
reviewed
Jul 25, 2018
| logger.debug('Websocket exception: %s', str(e)) | ||
| break | ||
| except CancelledError as e: | ||
| logger.debug('Websocket closed') |
Contributor
There was a problem hiding this comment.
Since this info will be useful on production setup as well. shouldn't this be info level instead of debug?
Contributor
Author
There was a problem hiding this comment.
How much do you care about a disconnected socket?
Contributor
There was a problem hiding this comment.
such failures might not be easily reproducible in dev so I think its important to capture it in prod
Contributor
Author
|
Testing this is honestly a big PITA. Even if code coverage is |
shahbazn
approved these changes
Jul 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Catch the proper exception and remove socket from memory.
The problem looks like this in the console:
Note for myself: asyncio and exceptions goes well like 🐈 and 🐕