Problem: some tests are not activated#2390
Merged
kansi merged 22 commits intobigchaindb:masterfrom Aug 8, 2018
Merged
Conversation
Solution: Remove core.py. Refactor BigchainDB Class to remove inheritance from Bigchain.
Solution: Remove core.py. Refactor BigchainDB Class to remove inheritance from Bigchain.
…its, as I don't know what I'm doing, and I can't experiment without running the CI... Sorry in advance!
…its, as I don't know what I'm doing, and I can't experiment without running the CI... Sorry in advance!
…gchaindb into z-bowen-remove_bigchain_class
…ivate method, so I had to align with that.
Solution: resolved merge conflicts to excavate Block class from my branch
Solution: Merged and repushed
Solution: Merge changes into Master
Solution: activate and remove or fix tests
16 tasks
Codecov Report
@@ Coverage Diff @@
## master #2390 +/- ##
==========================================
+ Coverage 88% 88.22% +0.21%
==========================================
Files 40 40
Lines 2310 2310
==========================================
+ Hits 2033 2038 +5
+ Misses 277 272 -5 |
Solution: Merge the changes from master that fix this test, and remove the skip
… during merge Solution: Replaced the skip
z-bowen
approved these changes
Jul 23, 2018
kansi
approved these changes
Aug 8, 2018
Contributor
|
There are still tests in |
Contributor
Author
|
I think it should not be skipped but I have to check again. Will remove it another PR anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: activate and remove or fix tests
see #2381
WARNING: I skipped the
test_get_spent_issue_1271test because it is handled in #2389if #2389 is merged before this PR then the master needs to be merged in here and the skip mark needs to be removed