Problem: Block parameters are not required anymore#2374
Problem: Block parameters are not required anymore#2374kansi merged 32 commits intobigchaindb:masterfrom
Conversation
Solution: add wget to the requirements for docs
Solution: Remove core.py. Refactor BigchainDB Class to remove inheritance from Bigchain.
Solution: Remove core.py. Refactor BigchainDB Class to remove inheritance from Bigchain.
…its, as I don't know what I'm doing, and I can't experiment without running the CI... Sorry in advance!
…its, as I don't know what I'm doing, and I can't experiment without running the CI... Sorry in advance!
…gchaindb into z-bowen-remove_bigchain_class
…ivate method, so I had to align with that.
Solution: resolved merge conflicts to excavate Block class from my branch
Solution: Merged and repushed
Solution: Merge changes into Master
Solution: remove Block parameters
Codecov Report
@@ Coverage Diff @@
## master #2374 +/- ##
==========================================
- Coverage 88.22% 88.16% -0.07%
==========================================
Files 40 40
Lines 2310 2298 -12
==========================================
- Hits 2038 2026 -12
Misses 272 272 |
bigchaindb/tendermint/lib.py
Outdated
| TX_IN_BACKLOG = 'backlog' | ||
| """return if transaction is in backlog""" | ||
| TX_UNDECIDED = 'undecided' | ||
| """return if tx is in undecided block""" |
There was a problem hiding this comment.
These are not needed anymore.
There was a problem hiding this comment.
ah, so the only one that stays is the TX_VALID?
There was a problem hiding this comment.
both TX_UNDECIDED and TX_VALID are not needed anymore.
There was a problem hiding this comment.
ok, will remove it.
|
Did you do a search to find all instances of |
|
@ttmc yes, for the ones that are currently removed. If you find occurrences of |
Solution: remove transaction parameter
|
I think we can get rid of |
👍 |
Solution: remove the status from transactions
bigchaindb/tendermint/lib.py
Outdated
|
|
||
| if include_status: | ||
| return transaction, self.TX_VALID if transaction else None | ||
| return transaction, 'valid' if transaction else None |
There was a problem hiding this comment.
I think the 'valid' should go away here too.
There was a problem hiding this comment.
Then I need to change the whole function and remove include_status too. I can do it if we want that.
There was a problem hiding this comment.
I think include_status is only used in the above if condition?
There was a problem hiding this comment.
yes, it's only in the if.
Solution: remove the status from transactions
Solution: tx is already the id
| for txid in txids: | ||
| tx, status = self.get_transaction(txid, True) | ||
| if status == self.TX_VALID: | ||
| yield tx |
There was a problem hiding this comment.
The original code seems to return tx class but the new code returns dict ?
Solution: return tx class instead of dict
7 participants
Solution: remove Block parameters
remove parameters mentioned here
depending on PR #2366
(when #2366 is merged I'll update this PR so that it can be merged)