Problem: 2 implementations of fastquery exist.#2365
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2365 +/- ##
==========================================
+ Coverage 86.64% 87.06% +0.42%
==========================================
Files 38 38
Lines 2126 2126
==========================================
+ Hits 1842 1851 +9
+ Misses 284 275 -9 |
| assert res == gof() | ||
|
|
||
|
|
||
| @pytest.mark.tendermint |
There was a problem hiding this comment.
I don't know if we need to mark them for tendermint yet. Maybe fixing them but still skipping them is better, @kansi ?
There was a problem hiding this comment.
And some parts of this file are also changed by @z-bowen s PR: https://github.com/bigchaindb/bigchaindb/pull/2366/files#diff-5dbcdadd05006f510ee75ac7dae5db47
There was a problem hiding this comment.
It does not make sense to change tests that are not executed. Also, if the tests have value, why disable them?
There was a problem hiding this comment.
As far as I know, making tests 'work again' was supposed to be an extra step. I don't mind if we change them in here and make them work.
There was a problem hiding this comment.
I concur with @ldmberman , we have been modifying tests in other PRs which aren't enabled. That doesn't give any insight into whether the test actually passes or not. Also, I really don't mind having more tests 😄
Solution: Remove the old deprecated implementation. Update the tests.
Solution: Fix the tests.
| with patch('bigchaindb.fastquery.FastQuery.get_outputs_by_public_key') as get_outputs: | ||
| from bigchaindb.tendermint.lib import BigchainDB | ||
|
|
||
| go = 'bigchaindb.tendermint.fastquery.FastQuery.get_outputs_by_public_key' |
There was a problem hiding this comment.
A short of get_outputs :)
There was a problem hiding this comment.
Yes , figured it out, thats why updated. 👍
5 participants
Solution: Remove the old deprecated implementation. Update the tests.