Problem: Tendermint configuration not present in BigchainDB config#2342
Problem: Tendermint configuration not present in BigchainDB config#2342muawiakh merged 10 commits intobigchaindb:masterfrom
Conversation
ttmc
left a comment
ttmc
left a comment
There was a problem hiding this comment.
Please also mention these new configuration settings in the docs, in bigchaindb/docs/server/source/server-reference/configuration.md
|
As far as I can see, the config is not taken into account when the Tendermint endpoint is buillt in |
ttmc
left a comment
ttmc
left a comment
There was a problem hiding this comment.
There doesn't seem to be any code that uses conf['tendermint']['host'] or port. Maybe I'm missing something.
bigchaindb/core.py
Outdated
| """return if transaction is in backlog""" | ||
|
|
||
| def __init__(self, connection=None): | ||
| def __init__(self, tendermint_host=None, tendermint_port=None, connection=None): |
There was a problem hiding this comment.
I don't think we need this, the user can use the config file .bigchaindb or the environment variables.
bigchaindb/core.py
Outdated
| self.endpoint = 'http://{}:{}/'.format(self.tendermint_host, self.tendermint_port) | ||
| self.mode_list = ('broadcast_tx_async', | ||
| 'broadcast_tx_sync', | ||
| 'broadcast_tx_commit') |
There was a problem hiding this comment.
This code has been added to the old core.py. As a part of the cleanup, we decided not to add any code to the older files. So, it would be better to move this to tendermint/lib.py
|
|
||
| **Default values** | ||
|
|
||
| If (no environment variables were set and there's no local config file), or you used `bigchaindb -y configure localmongodb` to create a default local config file for a `localmongodb` backend, then the defaults will be: |
There was a problem hiding this comment.
This line about how the environment variables, config file and default values are used to determine the run-time value of each configuration setting isn't needed here because it's already explained at the top of this page.
There was a problem hiding this comment.
If you like, you could add a short line to every subsection about default values, saying something like, "To understand how the default value of a setting affects the run-time value of a setting, see the top of this page."
|
I approved because GitHub was still showing my review status with the red X even though it was supposed to be showing the speech balloon to indicate that I'd made comments. It should still be showing the speech balloon, but I don't know how to make that happen without making a new comment. GitHub! |
- Also remove redundant info from docs about default values
|
Docs server are failing, will be fixed by #2360 |
Codecov Report
@@ Coverage Diff @@
## master #2342 +/- ##
==========================================
- Coverage 83.07% 82.98% -0.09%
==========================================
Files 38 38
Lines 2245 2251 +6
==========================================
+ Hits 1865 1868 +3
- Misses 380 383 +3 |
Solution: Merged and repushed
Solution: Merge changes into Master
5 participants
Solution
Add Tendermint host, port to BigchainDB configuration
Issues Resolved
Resolves #2255