add python3 mummi, maestrowf#5
Merged
bhatiaharsh merged 5 commits intobhatiaharsh:bhatia-mummifrom Oct 10, 2019
Merged
Conversation
FrankD412
reviewed
Sep 17, 2019
FrankD412
left a comment
FrankD412
left a comment
There was a problem hiding this comment.
Overall, this looks fine to me. I just left a comment about Maestro's package.
| version('develop', branch='develop') | ||
| version('1.1.4', tag='v1.1.4') | ||
| version('1.1.2', tag='v1.1.2') | ||
| version('flux-sched', branch='bugfix/flux_broker') |
There was a problem hiding this comment.
This one points to the same branch as flux-dev, so it's redundant.
bhatiaharsh
reviewed
Sep 18, 2019
|
|
||
| homepage = "https://github.com/LLNL/maestrowf/" | ||
| url = "https://github.com/LLNL/maestrowf/archive/v1.1.2.tar.gz" | ||
| git = "https://github.com/LLNL/maestrowf.git" |
Owner
There was a problem hiding this comment.
Ok, so after having thought about it, i think i am sure this is not a good idea. by changing the default download method to git, we're forcing all users to set up proper ssh keys. whereas, by leaving it as path to tar gets around the problem, and makes the tool completely public!
here and below, we should have sha hash of all the downloadable releases. use git only for the branches and bug-fixes, like @FrankD412 had before.
Author
|
Okay ready for merge |
bhatiaharsh
pushed a commit
that referenced
this pull request
Jun 20, 2020
Whenever attempting to use any ncurses functionality within cscope, a
page fault would result within the ncurses library.
Program received signal SIGSEGV, Segmentation fault.
0x00007ffff7fad3cf in termattrs_sp () from .../lib/libncursesw.so.6
(gdb) bt
#0 0x00007ffff7fad3cf in termattrs_sp () from .../lib/libncursesw.so.6
#1 0x00007ffff7faa794 in _nc_setupscreen_sp () from .../lib/libncursesw.so.6
#2 0x00007ffff7fa614c in newterm_sp () from .../lib/libncursesw.so.6
#3 0x00007ffff7fa65b9 in newterm () from .../lib/libncursesw.so.6
#4 0x00007ffff7fa2970 in initscr () from .../lib/libncursesw.so.6
#5 0x0000000000403dc2 in main (argc=<optimized out>, argv=0x7fffffffcea8) at main.c:574
This is due to a conflict between libtinfo.so and libtinfow.so. Both are
linked into cscope:
$ ldd $(which cscope)
/bin/bash: .../lib/libtinfo.so.6: no version information available (required by /bin/bash)
linux-vdso.so.1 (0x00007fff5dbcb000)
libncursesw.so.6 => .../lib/libncursesw.so.6 (0x00007f435cc69000)
libtinfo.so.6 => .../lib/libtinfo.so.6 (0x00007f435cc2c000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f435ca29000)
libtinfow.so.6 => .../lib/libtinfow.so.6 (0x00007f435c9e8000)
/lib64/ld-linux-x86-64.so.2 (0x00007f435cca7000)
Specifically linking libtinfow.so instead of libtinfo.so resolves the
issue.
All instances of '...' above represent the path to the installed ncurses
for Spack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added all changes for python3