Skip to content

[NEW] Service account callbacks#6

Merged
bhardwajaditya merged 11 commits intoservice-accountsfrom
service-account-callbacks
Jun 27, 2019
Merged

[NEW] Service account callbacks#6
bhardwajaditya merged 11 commits intoservice-accountsfrom
service-account-callbacks

Conversation

@bhardwajaditya
Copy link
Copy Markdown
Owner

@bhardwajaditya bhardwajaditya commented Jun 18, 2019

A new broadcast room will be created for each service account to send broadcast messages from it.The name of broadcast will follow this nomenclature. broadcast_username.

broadcast-sa

@kb0304
Copy link
Copy Markdown
Collaborator

kb0304 commented Jun 25, 2019

The code looks good.
How are we handling the cases where the username of a service account is changed, a service account is deleted etc. ?

@bhardwajaditya
Copy link
Copy Markdown
Owner Author

The code looks good.
How are we handling the cases where the username of a service account is changed, a service account is deleted etc. ?

This is a regular private room, where owner is the service account so any such changes will be handled exactly how we handle existing private room

@kb0304
Copy link
Copy Markdown
Collaborator

kb0304 commented Jun 25, 2019

@bhardwajaditya Right the owner would change, but if I change the username of my SA from a to b, how would the name of the room change from broadcast_a to broadcast_b?

Coz if we don't do the change of room name, then after I change username of my SA to b, username a is free for someone to take, but the corresponding room belongs to me already, so a broadcast room will not be created for them.

@bhardwajaditya
Copy link
Copy Markdown
Owner Author

@bhardwajaditya Right the owner would change, but if I change the username of my SA from a to b, how would the name of the room change from broadcast_a to broadcast_b?

Coz if we don't do the change of room name, then after I change username of my SA to b, username a is free for someone to take, but the corresponding room belongs to me already, so a broadcast room will not be created for them.

Yes, you are right I didn't think of this. Will add a method to this to update that as well

@bhardwajaditya bhardwajaditya merged commit 6aa19d3 into service-accounts Jun 27, 2019
bhardwajaditya pushed a commit that referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants