Skip to content

Commit eefe37b

Browse files
authored
docs(adr-0011): narrow the offscreen rescue comment to the per-request surface policy (callstack#2465)
* docs(adr-0011): note the offscreen live rescue reads the tree's surface The offscreen guarantee's live rescue runs the runner's direct querySelector, which consumes the single activeApp that prepareActiveCommandContext resolved for the snapshot tree as well, including an in-place system surface. Record that the tree and the rescue read the same surface so the cell's rationale stays accurate. Closes callstack#2452 * docs(adr-0011): narrow the offscreen rescue comment to the per-request surface policy The snapshot capture and the live rescue are separate runner requests, and each calls prepareActiveCommandContext on its own, so only the selection policy is shared, not the surface instant. State that, and say plainly that a surface appearing or dismissing between the two requests is not detected. Closes callstack#2452 * docs(adr-0011): limit the shared surface seam to runner-routed captures An eligible iOS simulator snapshot is served by the host AX bridge (packages/platform-apple/src/snapshot-route.ts), which never reaches the runner's prepareActiveCommandContext. The rescue's direct querySelector always does, so the two requests share that surface policy only when the capture is runner-routed too - which is the case callstack#2448 forces for the system surface. Keep the unchanged statement that no surface identity crosses the two requests.
1 parent 3cd6341 commit eefe37b

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

‎packages/contracts/src/interaction-guarantees.ts‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,15 @@ const RUNTIME_TREE_SHARED_GUARANTEES = {
170170
// not the bulk one. Every other platform, and any backend that omits the
171171
// hook, refuses on the visibility resolver's verdict unchanged — this is a
172172
// rescue-only override, never a way to relax a genuine refusal.
173+
// The live read is a SEPARATE runner request (the direct querySelector), so
174+
// it shares the runner's prepareActiveCommandContext surface policy only with
175+
// a RUNNER-ROUTED capture: eligible simulator captures go to the host AX
176+
// bridge (packages/platform-apple/src/snapshot-route.ts), and a bridge-served
177+
// capture never reaches that seam. #2448 puts the system-surface case (the
178+
// web sign-in sheet) back on the runner, where both reads do share it. Either
179+
// way this is not a same-instant guarantee — no captured surface identity
180+
// crosses the two requests, so a surface that appears or dismisses between
181+
// them is undetected.
173182
offscreen: {
174183
kind: 'runtime',
175184
via: 'src/commands/interaction/runtime/resolution.ts#throwIfOffscreenInteractionTarget',

0 commit comments

Comments
 (0)