Skip to content

Squashed commit of the following: Fix issue35#44

Merged
bgrins merged 1 commit intobgrins:masterfrom
anaran:issue35squashed
Dec 15, 2013
Merged

Squashed commit of the following: Fix issue35#44
bgrins merged 1 commit intobgrins:masterfrom
anaran:issue35squashed

Conversation

@anaran
Copy link
Copy Markdown
Contributor

@anaran anaran commented Nov 28, 2013

commit e0ebe31
Author: Adrian Aichner [email protected]
Date: Thu Nov 28 00:00:12 2013 +0100

Partial documentation update, snippet import export improvements.

Change export format to parsed scriptSnippets form (like snippets.json).
Provide detailed error reporting on parsable, but invalid JSON import file.
Hide missingFileTypeExtensionSelect when exportTypeSelect.value === singleFile.innerText
Add initial section of README.md to devtools_import_export.js
as entry point for new users.

Add supporting images.

commit c17a865
Author: Adrian Aichner [email protected]
Date: Tue Nov 26 12:34:33 2013 +0100

Add Close link temporarily as workaround for chrome canary crash.

See https://code.google.com/p/chromium/issues/detail?id=323031

commit 507af51
Author: Adrian Aichner [email protected]
Date: Mon Nov 25 21:05:31 2013 +0100

Only import and export snippets via localStorage.scriptSippets.

Simplify use by skipping itermediate popup with links.
As a consequence the window cannot live inside a tab.
Add a few options to support personal preferences.
Please be aware of https://code.google.com/p/chromium/issues/detail?id=323031
when testing in canary Chrome.

commit 64449eb
Author: Adrian Aichner [email protected]
Date: Sun Nov 3 17:20:57 2013 +0100

Add overview section for Typical Use Cases, add overview links to slide show

commit 6c6d34d
Author: Adrian Aichner [email protected]
Date: Sun Nov 3 17:13:13 2013 +0100

Request download settings help for navigator.language

commit e171a93
Author: Adrian Aichner [email protected]
Date: Sat Nov 2 10:30:33 2013 +0100

minor fixes for links, markdown, typos.

commit e3cd836
Author: Adrian Aichner [email protected]
Date: Sat Nov 2 09:30:21 2013 +0100

Fix bad fragment specifier replacement.

commit e3afcd1
Author: Adrian Aichner [email protected]
Date: Sat Nov 2 09:23:08 2013 +0100

poor man's slide show for typical use cases is in.

commit 959e376
Author: Adrian Aichner [email protected]
Date: Sat Nov 2 08:55:32 2013 +0100

try fragment links

commit e4e9332
Author: Adrian Aichner [email protected]
Date: Sat Nov 2 08:04:22 2013 +0100

trying to stare down markdown

commit ac96525
Author: Adrian Aichner [email protected]
Date: Sat Nov 2 07:52:40 2013 +0100

try poor man slide show

commit 52b343d
Author: Adrian Aichner [email protected]
Date: Sat Nov 2 06:46:57 2013 +0100

Remove inline markup.

commit 9042073
Author: Adrian Aichner [email protected]
Date: Sat Nov 2 06:38:59 2013 +0100

Testing png-based tutorial of snippet functionality.

commit f737869
Author: Adrian Aichner [email protected]
Date: Sat Nov 2 04:43:48 2013 +0100

Add screenshots for basic feature set.

GIF animation quality is poor (missing layers, missing pixes in toolbar).
Would be good if PNG files could be used instead, perhaps as a manual slide show.

commit 60a5bde
Author: Adrian Aichner [email protected]
Date: Sat Nov 2 02:12:40 2013 +0100

Move devtools_import_export.js, html_i18n_content.js to their own directories.

Carry over minor changes I had made to html_i18n_content.js.

commit 692da68
Author: Adrian Aichner [email protected]
Date: Sat Nov 2 00:59:18 2013 +0100

Add header comment hopefully sufficient for adept users

commit c2b5aa9
Author: Adrian Aichner [email protected]
Date: Fri Nov 1 23:45:50 2013 +0100

Deleting all snippets works in Chrome 30 now as well.

Improve presentation of alert information for the two use cases:
To inspect localStorage
To import/export devtools source snippets

commit 9e845f9
Author: Adrian Aichner [email protected]
Date: Fri Nov 1 21:11:06 2013 +0100

Make user confirm successful localStorage download in delete all snippets.

commit ef563e6
Author: Adrian Aichner [email protected]
Date: Fri Nov 1 20:41:56 2013 +0100

delete all snippets, import snippets from localStorage download.

Dynamically updating localStorage and snippet counts.
Tested only in chrome canary.

commit 31a89ef
Author: Adrian Aichner [email protected]
Date: Fri Nov 1 02:57:17 2013 +0100

move devtools_import_export.js

commit af15be0
Author: Adrian Aichner [email protected]
Date: Thu Oct 31 00:10:32 2013 +0100

Format JS

Comparing Format JS changes is still difficult without ignore whitespace support.

commit bdb320b
Author: Adrian Aichner [email protected]
Date: Wed Oct 30 23:56:22 2013 +0100

Integrate latest functionality of collect_command_history.js

Drop window.open strWindowFeatures argument to open in tabs instead of popups, still via anchor click listeners.

commit e1333f7
Author: Adrian Aichner [email protected]
Date: Tue Oct 29 21:24:19 2013 +0100

Run UI in new tab, both for webpage and devtools localStorage import/export.

Need to open window from callback to open new tab instead of window.
Add backward compatibility for snippet import in Google Chrome 30 where createFile only takes three arguments.

commit 1844c42
Author: Adrian Aichner [email protected]
Date: Tue Oct 29 11:39:34 2013 +0100

Format JS

commit b1ef390
Author: Adrian Aichner [email protected]
Date: Mon Oct 28 21:42:40 2013 +0100

Complete import into orion with 'Import local file...' on kuckuck.

All snippets were exported to download location C:\GoogleChromeSnippets using snippet devtools_import_export.js, then drop onto orion's "import a file or zip" popup.
File input dialog does not support multiple files!

commit 4e621fc
Author: Adrian Aichner [email protected]
Date: Mon Oct 28 02:58:39 2013 +0100

Add comment: // .innerText contains newline characters in Chrome, while .textContent loses them.

commit e0ebe31
Author: Adrian Aichner <[email protected]>
Date:   Thu Nov 28 00:00:12 2013 +0100

    Partial documentation update, snippet import export improvements.

    Change export format to parsed scriptSnippets form (like snippets.json).
    Provide detailed error reporting on parsable, but invalid JSON import file.
    Hide missingFileTypeExtensionSelect when exportTypeSelect.value === singleFile.innerText
    Add initial section of README.md to devtools_import_export.js
    as entry point for new users.

    Add supporting images.

commit c17a865
Author: Adrian Aichner <[email protected]>
Date:   Tue Nov 26 12:34:33 2013 +0100

    Add Close link temporarily as workaround for chrome canary crash.

    See https://code.google.com/p/chromium/issues/detail?id=323031

commit 507af51
Author: Adrian Aichner <[email protected]>
Date:   Mon Nov 25 21:05:31 2013 +0100

    Only import and export snippets via localStorage.scriptSippets.

    Simplify use by skipping itermediate popup with links.
    As a consequence the window cannot live inside a tab.
    Add a few options to support personal preferences.
    Please be aware of https://code.google.com/p/chromium/issues/detail?id=323031
    when testing in canary Chrome.

commit 64449eb
Author: Adrian Aichner <[email protected]>
Date:   Sun Nov 3 17:20:57 2013 +0100

    Add overview section for Typical Use Cases, add overview links to slide show

commit 6c6d34d
Author: Adrian Aichner <[email protected]>
Date:   Sun Nov 3 17:13:13 2013 +0100

    Request download settings help for navigator.language

commit e171a93
Author: Adrian Aichner <[email protected]>
Date:   Sat Nov 2 10:30:33 2013 +0100

    minor fixes for links, markdown, typos.

commit e3cd836
Author: Adrian Aichner <[email protected]>
Date:   Sat Nov 2 09:30:21 2013 +0100

    Fix bad fragment specifier replacement.

commit e3afcd1
Author: Adrian Aichner <[email protected]>
Date:   Sat Nov 2 09:23:08 2013 +0100

    poor man's slide show for typical use cases is in.

commit 959e376
Author: Adrian Aichner <[email protected]>
Date:   Sat Nov 2 08:55:32 2013 +0100

    try fragment links

commit e4e9332
Author: Adrian Aichner <[email protected]>
Date:   Sat Nov 2 08:04:22 2013 +0100

    trying to stare down markdown

commit ac96525
Author: Adrian Aichner <[email protected]>
Date:   Sat Nov 2 07:52:40 2013 +0100

    try poor man slide show

commit 52b343d
Author: Adrian Aichner <[email protected]>
Date:   Sat Nov 2 06:46:57 2013 +0100

    Remove inline markup.

commit 9042073
Author: Adrian Aichner <[email protected]>
Date:   Sat Nov 2 06:38:59 2013 +0100

    Testing png-based tutorial of snippet functionality.

commit f737869
Author: Adrian Aichner <[email protected]>
Date:   Sat Nov 2 04:43:48 2013 +0100

    Add screenshots for basic feature set.

    GIF animation quality is poor (missing layers, missing pixes in toolbar).
    Would be good if PNG files could be used instead, perhaps as a manual slide show.

commit 60a5bde
Author: Adrian Aichner <[email protected]>
Date:   Sat Nov 2 02:12:40 2013 +0100

    Move devtools_import_export.js, html_i18n_content.js to their own directories.

    Carry over minor changes I had made to html_i18n_content.js.

commit 692da68
Author: Adrian Aichner <[email protected]>
Date:   Sat Nov 2 00:59:18 2013 +0100

    Add header comment hopefully sufficient for adept users

commit c2b5aa9
Author: Adrian Aichner <[email protected]>
Date:   Fri Nov 1 23:45:50 2013 +0100

    Deleting all snippets works in Chrome 30 now as well.

    Improve presentation of alert information for the two use cases:
    To inspect localStorage
    To import/export devtools source snippets

commit 9e845f9
Author: Adrian Aichner <[email protected]>
Date:   Fri Nov 1 21:11:06 2013 +0100

    Make user confirm successful localStorage download in delete all snippets.

commit ef563e6
Author: Adrian Aichner <[email protected]>
Date:   Fri Nov 1 20:41:56 2013 +0100

    delete all snippets, import snippets from localStorage download.

    Dynamically updating localStorage and snippet counts.
    Tested only in chrome canary.

commit 31a89ef
Author: Adrian Aichner <[email protected]>
Date:   Fri Nov 1 02:57:17 2013 +0100

    move devtools_import_export.js

commit af15be0
Author: Adrian Aichner <[email protected]>
Date:   Thu Oct 31 00:10:32 2013 +0100

    Format JS

    Comparing Format JS changes is still difficult without ignore whitespace support.

commit bdb320b
Author: Adrian Aichner <[email protected]>
Date:   Wed Oct 30 23:56:22 2013 +0100

    Integrate latest functionality of collect_command_history.js

    Drop window.open strWindowFeatures argument to open in tabs instead of popups, still via anchor click listeners.

commit e1333f7
Author: Adrian Aichner <[email protected]>
Date:   Tue Oct 29 21:24:19 2013 +0100

    Run UI in new tab, both for webpage and devtools localStorage import/export.

    Need to open window from callback to open new tab instead of window.
    Add backward compatibility for snippet import in Google Chrome 30 where createFile only takes three arguments.

commit 1844c42
Author: Adrian Aichner <[email protected]>
Date:   Tue Oct 29 11:39:34 2013 +0100

    Format JS

commit b1ef390
Author: Adrian Aichner <[email protected]>
Date:   Mon Oct 28 21:42:40 2013 +0100

    Complete import into orion with 'Import local file...' on kuckuck.

    All snippets were exported to download location C:\GoogleChromeSnippets using snippet devtools_import_export.js, then drop onto orion's "import a file or zip" popup.
    File input dialog does not support multiple files!

commit 4e621fc
Author: Adrian Aichner <[email protected]>
Date:   Mon Oct 28 02:58:39 2013 +0100

    Add comment: // .innerText contains newline characters in Chrome, while .textContent loses them.
@addyosmani
Copy link
Copy Markdown

👍

@bgrins bgrins merged commit a51f7fa into bgrins:master Dec 15, 2013
@bgrins
Copy link
Copy Markdown
Owner

bgrins commented Dec 15, 2013

@anaran thanks for doing this. I've made a new folder called import-export in the root and put it here, since it is a different kind of snippet than the others. It is here: https://github.com/bgrins/devtools-snippets/tree/master/import-export/chrome

@anaran
Copy link
Copy Markdown
Contributor Author

anaran commented Dec 15, 2013

It's great to see this has landed! Thank @bgrins !

I will follow up with some link mending and documentation cleanup in due course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants