Implement draft-ietf-sidrops-8210bis-10 #88
Conversation
It will now sort entries before they go out, Sorted by: Largest CIDR > Largest Max Length > IP address
|
@job Looking for a sanity check on this sorting logic. I've attached a pcap that shows the ordering that it now does: |
cmd/rtrdump/rtrdump.go
Outdated
| Serial = flag.Int("serial.value", 0, "Serial number") | ||
| Session = flag.Int("session.id", 0, "Session ID") | ||
|
|
||
| FlagVersion = flag.Int("rtr.version", 1, "What RTR version you want to use, Version 2 is draft-ietf-sidrops-8210bis-10") |
There was a problem hiding this comment.
probably want to set 2 as the default, after all the client dictates what the actual protocol version is going to be
There was a problem hiding this comment.
If I don't do this, then I cannot rtrdump Cloudflare's RTR server, it just instantly hangs up.
I suspect there are more RTR servers like this
There was a problem hiding this comment.
If the server immediately hangs up, print a warning suggesting the operator to try a different RTR version.
rtrdump in StayRTR primarily exists to conform the functioning of StayRTR.
Some random RTR servers in the wild being incompatible without proper error messages can't be helped.
Having rtrdump by default be downgraded to earlier protocols because of buggy third-party implementations stifles innovation.
|
looks good to me |
|
I'd like to avoid having the default version 2 being a tied to a draft of
what V2 is going to look like.
When it gets adopted and everything still matches then it's fine (IMHO) to
switch the default.
I know it's unlikely it's going to change, but I've been bitten by software
doing this before ;)
…On Wed, 22 Feb 2023, 18:06 Job Snijders, ***@***.***> wrote:
looks good to me
—
Reply to this email directly, view it on GitHub
<#88 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALPK4SJN6FJYHOBHXGHXALWYZITRANCNFSM6AAAAAAVEUDFWA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
It's been adopted, and approved by IESG for publication; draft-ietf-sidrops-8210bis is in the RFC Editor queue (see https://www.rfc-editor.org/current_queue.php and search for 8210)... so apart from spelling errors, its not going to change |
|
perhaps makes sense to also have a |
Addresses: #88 (comment)
This reverts commit f40e9cc. Cannot do this, Cloudflare's RTR server cannot deal with this
Just in case!
This currently happens with rtr.rpki.cloudflare.com:8282
commit e98648f (HEAD -> draft-ietf-sidrops-8210bis-10, origin/draft-ietf-sidrops-8210bis-10)
Author: Ben Cartwright-Cox [email protected]
Date: Wed Feb 22 17:36:06 2023 +0000
commit 187410d
Author: Ben Cartwright-Cox [email protected]
Date: Wed Feb 22 17:18:46 2023 +0000
commit 3b73956
Author: Ben Cartwright-Cox [email protected]
Date: Wed Feb 22 15:17:26 2023 +0000