Small codebase refactors / cleanups #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value of runtime.GOMAXPROCS is the number of CPUs. So there is no need for this line to exist.
They serve the same function, but it's more understandable what is going on. go-static-check raises this as a warning
Plus remove a pointless fmt.sprintf()
IP.Equal handles some edge cases inside how IP addresses are represented rather than just flat out comparing some byte arrays blindly.
ties
reviewed
Jan 19, 2023
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| defer ff.Close() |
ties
approved these changes
Jan 19, 2023
Collaborator
ties
left a comment
ties
left a comment
There was a problem hiding this comment.
Imo this is a good set of cleanups and small refactorings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the output of my initial pass through the code, fixing things that either are small "this could go wrong" or just simplifying some areas out completely.
I also improved the error messages from the packages, sometimes just setting their capitalisation to what you would mostly expect from go programs, but also adding clarification on some of them.