Skip to content

saveErrorMessage() bug, and Cypress test improvements#477

Merged
galbus merged 13 commits intomainfrom
s-7904-el-libero-wordpress-issues-since-update
Jan 7, 2026
Merged

saveErrorMessage() bug, and Cypress test improvements#477
galbus merged 13 commits intomainfrom
s-7904-el-libero-wordpress-issues-since-update

Conversation

@galbus
Copy link
Copy Markdown
Contributor

@galbus galbus commented Dec 23, 2025

This pull request prepares the plugin for the 6.0.4 release and includes several important codebase enhancements and fixes. The main changes are a bug fix for error message handling, improvements to the Cypress test suite, and enforcing best practices by adding ABSPATH checks to all PHP files. There are also dependency updates and version bumps across key files.

Bug Fixes:

  • Fixed a bug in the saveErrorMessage() method where the integration method was incorrectly checked for the plugin instead of the post, addressing issues with unexpected 404 error messages being saved.

Testing Improvements:

  • Enhanced the Cypress test suite by adding more assertions, testing additional post statuses, and improving the createPost helper to handle post dates and reliably parse post IDs.

Security and Best Practices:

  • Added defined('ABSPATH') || exit; at the top of all PHP files in to prevent direct file access. This was required to satisfy our PHP Plugin check, which has recently introduced this rule.

Dependency and Version Updates:

  • Updated Cypress dependency to ^15.8.1 in package.json.
  • Bumped plugin version to 6.0.4-rc.1 in package.json, readme.txt, and speechkit.php.

Coding Standards:

  • Updated phpcs.xml to allow the ABSPATH check side effect in files that define classes, aligning with the new security best practice.

@galbus galbus self-assigned this Dec 23, 2025
@galbus galbus added enhancement wip Work in Progress php Pull requests that update Php code javascript Pull requests that update Javascript code labels Dec 23, 2025
@linear
Copy link
Copy Markdown

linear bot commented Dec 23, 2025

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 72 out of 73 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug javascript Pull requests that update Javascript code php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants