Skip to content

[Merged by Bors] - 0.10 Blog Post: Add ECS optimizations section#549

Closed
james7132 wants to merge 12 commits intobevyengine:release-0.10.0from
james7132:patch-2
Closed

[Merged by Bors] - 0.10 Blog Post: Add ECS optimizations section#549
james7132 wants to merge 12 commits intobevyengine:release-0.10.0from
james7132:patch-2

Conversation

@james7132
Copy link
Copy Markdown
Member

I split out the adaptive batching part from the rest of the optimizations work since that has a user-visible impact.

Copy link
Copy Markdown
Member

@LiamGallagher737 LiamGallagher737 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some grammar and spelling things

Co-authored-by: JoJoJet <[email protected]>
Co-authored-by: Liam Gallagher <[email protected]>
@james7132 james7132 requested review from LiamGallagher737 and joseph-gio and removed request for LiamGallagher737 February 26, 2023 07:28
Co-authored-by: JoJoJet <[email protected]>
@joseph-gio
Copy link
Copy Markdown
Member

From what I can tell, the previous blog posts don't link back to specific pull requests. Not sure if we want to start doing that here.

@alice-i-cecile
Copy link
Copy Markdown
Member

From what I can tell, the previous blog posts don't link back to specific pull requests. Not sure if we want to start doing that here.

I think that it's valuable, especially for deeply technical changes like this. There's some portion of the audience who will be fascinated and want to hear about the exact details, and giving them an actual link is nice.

I also think it does a much better job fairly assigning credit to the authors: being able to quickly jump to the actual work that caught your eye is super useful from the perspective of trying to evaluate skills (for hiring or otherwise).

@joseph-gio
Copy link
Copy Markdown
Member

joseph-gio commented Feb 28, 2023

Good points. It might be good to decide on a standard style for referencing PRs, though?

@cart
Copy link
Copy Markdown
Member

cart commented Feb 28, 2023

I also think it does a much better job fairly assigning credit to the authors: being able to quickly jump to the actual work that caught your eye is super useful from the perspective of trying to evaluate skills (for hiring or otherwise).

I think this topic is complicated because the set of PRs that should be shared with our users (because they are useful / interesting) don't always line up with the PRs that were the most amount of work / the most technical / etc.

If we start using "linking to PRs" as a regular part of our credit system, we risk bloating the blog post with noise. And we also risk only crediting things that are "exciting, linkable via a single PR, and easy to digest".

Those are the main reasons I've been avoiding doing this unless absolutely necessary.

@james7132
Copy link
Copy Markdown
Member Author

james7132 commented Feb 28, 2023

The main reason why I wanted to link the PRs was the proof in the pudding (i.e. the benchmark results) are most readily visible there. Moving them to the main blog post, particularly with how many of them there are, might be noisier than if we just linked them.

Might be worth moving the link to the end of each blurb instead of at the start, where it interjects into one's consciousness more aggressively.

@cart
Copy link
Copy Markdown
Member

cart commented Feb 28, 2023

Yeah I think its reasonably justified in this context / the current state of things is pretty good.

@cart
Copy link
Copy Markdown
Member

cart commented Mar 2, 2023

bors r+

bors bot pushed a commit that referenced this pull request Mar 2, 2023
I split out the adaptive batching part from the rest of the optimizations work since that has a user-visible impact.

Co-authored-by: James Liu <[email protected]>
@bors
Copy link
Copy Markdown

bors bot commented Mar 2, 2023

Pull request successfully merged into release-0.10.0.

Build succeeded:

@bors bors bot changed the title 0.10 Blog Post: Add ECS optimizations section [Merged by Bors] - 0.10 Blog Post: Add ECS optimizations section Mar 2, 2023
@bors bors bot closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants