add release notes for query iter sorts#1460
Conversation
release-content/0.14/release-notes/13417_implement_the_full_set_of_sort_methods_on_QueryIter.md
Outdated
Show resolved
Hide resolved
|
So while writing this, I have just discovered something interesting: The PR implementing the full set of sort methods didn't actually implement the full set of sort methods... |
|
otherwise, this should be ready for first review! |
|
Said missing feature: bevyengine/bevy#14040 |
release-content/0.14/release-notes/13417_implement_the_full_set_of_sort_methods_on_QueryIter.md
Outdated
Show resolved
Hide resolved
release-content/0.14/release-notes/13417_implement_the_full_set_of_sort_methods_on_QueryIter.md
Outdated
Show resolved
Hide resolved
release-content/0.14/release-notes/13417_implement_the_full_set_of_sort_methods_on_QueryIter.md
Show resolved
Hide resolved
release-content/0.14/release-notes/13417_implement_the_full_set_of_sort_methods_on_QueryIter.md
Show resolved
Hide resolved
release-content/0.14/release-notes/13417_implement_the_full_set_of_sort_methods_on_QueryIter.md
Outdated
Show resolved
Hide resolved
release-content/0.14/release-notes/13417_implement_the_full_set_of_sort_methods_on_QueryIter.md
Outdated
Show resolved
Hide resolved
| Keep in mind that the lensing does add some overhead, so these query iterator sorts do not perform equally to a manual sort on average. However, this *strongly* depends on workload, so best test it yourself if relevant! | ||
| The sorts themselves are not yet cached between system runs, and these methods only sort iterators, not underlying query storage. | ||
|
|
||
| Note that query iteration might happen in a deterministic order for now, but that may change anytime over future releases. |
There was a problem hiding this comment.
I think this should be cut.
There was a problem hiding this comment.
I cut the last 2 sentences. Some people care a lot about sort performance, so I think the mention of it should remain.
It is not some simple "sort sugar" like itertools, but that might not be clear.
release-content/0.14/release-notes/13417_implement_the_full_set_of_sort_methods_on_QueryIter.md
Outdated
Show resolved
Hide resolved
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Good writing and nice examples, but too long :) I've left some suggestions on what can be cut down.
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Fantastic; thanks for being so prompt and receptive to the editing :)
|
No worries, I am not too familiar with the bevy release note style, and did put this together rather quickly after all ^^ |
2 participants
Closes #1322
This is an initial draft, I still want to have a read through the existing release notes, and match the language/tone if necessary.I'll also see if there's anything I would like to expand upon/change/cut before requesting review.