Change Window::physical_cursor_position to use the physical size of the window#9657
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Aug 31, 2023
Merged
Conversation
…tion is inside the window but it constructs the bounding rect for the window using its logical size and then checks to see if the cursor's physical position in inside the rect. When the physical size is smaller than the logical size, this leaves a dead zone where the cursor is over the window but its position is unreported. This commit changes the rect so it's the physical size.
ickshonpe
changed the title
Window::physical_cursor_position checks to see if the cursor's posi…Window::physical_cursor_position to use the physical size of the window
rparrett
approved these changes
Aug 31, 2023
Contributor
rparrett
left a comment
rparrett
left a comment
There was a problem hiding this comment.
Makes sense to me / seems to fix the issue.
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Aug 31, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
… the window (bevyengine#9657) # Objective `Window::physical_cursor_position` checks to see if the cursor's position is inside the window but it constructs the bounding rect for the window using its logical size and then checks to see if it contains the cursor's physical position. When the physical size is smaller than the logical size, this leaves a dead zone where the cursor is over the window but its position is unreported. fixes: bevyengine#9656 ## Solution Use the physical size of the window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Window::physical_cursor_positionchecks to see if the cursor's position is inside the window but it constructs the bounding rect for the window using its logical size and then checks to see if it contains the cursor's physical position. When the physical size is smaller than the logical size, this leaves a dead zone where the cursor is over the window but its position is unreported.fixes: #9656
Solution
Use the physical size of the window.