Fix erronenous glam version#9653
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Aug 31, 2023
Merged
Conversation
nicopap
added
C-Dependencies
Contributor
|
The only one of these that has to be bumped is bevy_math. Do we have any policy for keeping the versions across crates in sync? |
Contributor
|
I'm not aware of any policy but it makes sense to me to just keep the same version everywhere |
Contributor
Author
|
It's just better to keep them in sync. |
mockersf
approved these changes
Aug 31, 2023
Member
mockersf
left a comment
mockersf
left a comment
There was a problem hiding this comment.
It's just better to keep them in sync.
I (probably) disagree in theory. Bumping everywhere for a specific case reduces compatibility for people that don't use that case.
That said, I don't think we should care about that for Bevy for now when our current compatibility policy is "just update everything"
alice-i-cecile
approved these changes
Aug 31, 2023
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - Fix compilation issue with wrongly specified glam version - bevy uses `Vec2::INFINITY`, depends on `0.24` (equivalent to `0.24.0`) yet it was only introduced in version `0.24.1` Context: https://discord.com/channels/691052431525675048/692572690833473578/1146586570787397794 ## Solution - Bump glam version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Vec2::INFINITY, depends on0.24(equivalent to0.24.0) yet it was only introduced in version0.24.1Context: https://discord.com/channels/691052431525675048/692572690833473578/1146586570787397794
Solution