Fix anonymous set name stack overflow#9650
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Aug 31, 2023
Merged
Conversation
alice-i-cecile
added
C-Bug
hymm
force-pushed
the
ambiguity_stack_overflow
branch
from
e4e47db to
55184f1
Compare
hymm
force-pushed
the
ambiguity_stack_overflow
branch
from
55184f1 to
b39c4e2
Compare
alice-i-cecile
approved these changes
Aug 31, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - Fixes bevyengine#9641 - Anonymous sets are named by their system members. When `ScheduleBuildSettings::report_sets` is on, systems are named by their sets. So when getting the anonymous set name this would cause an infinite recursion. ## Solution - When getting the anonymous system set name, don't get their system's names with the sets the systems belong to. ## Other Possible solutions - An alternate solution might be to skip anonymous sets when getting the system's name for an anonymous set's name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
.run_if(in_state(...))#9641ScheduleBuildSettings::report_setsis on, systems are named by their sets. So when getting the anonymous set name this would cause an infinite recursion.Solution
Other Possible solutions