Skip to content

Fixing some doc comments#9646

Merged
alice-i-cecile merged 11 commits intobevyengine:mainfrom
EmiOnGit:docs
Aug 31, 2023
Merged

Fixing some doc comments#9646
alice-i-cecile merged 11 commits intobevyengine:mainfrom
EmiOnGit:docs

Conversation

@EmiOnGit
Copy link
Copy Markdown
Contributor

Objective

I've been collecting some mistakes in the documentation and fixed them

Comment on lines -7 to -9
#[cfg(doc)]
use bevy_hierarchy::BuildChildren;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the doc import? I find it better than repeating multiple times the full path in-line.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links were not working on my end.
See latest doc

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh I see. For this one, this is a correct change.

#[cfg(target_os = "android")]
pub static ANDROID_APP: std::sync::OnceLock<AndroidApp> = std::sync::OnceLock::new();

/// A [`Plugin`] that uses [`winit`] to create and manage windows, and receive window and input
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the crate-level links? I find them useful.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the docs the links are not displayed and look a bit weird in return.
Is this still wanted behavior?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They work on locally generated versions of the doc (by running cargo doc --open) which is generally more useful, since the search bar can search for docs on more than a single dependency.

But I'm OK with removing them if they don't works on docs.rs

@alice-i-cecile alice-i-cecile added the C-Docs An addition or correction to our documentation label Aug 31, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 31, 2023
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 31, 2023
Merged via the queue into bevyengine:main with commit 3527288 Aug 31, 2023
@EmiOnGit EmiOnGit deleted the docs branch August 31, 2023 22:57
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
# Objective
I've been collecting some mistakes in the documentation and fixed them

---------

Co-authored-by: Emi <[email protected]>
Co-authored-by: Nicola Papale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants