Change Urect::width & Urect::height to be const#9640
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Aug 30, 2023
Merged
Change Urect::width & Urect::height to be const#9640alice-i-cecile merged 1 commit intobevyengine:mainfrom
Urect::width & Urect::height to be const#9640alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
Contributor
Author
|
Also just saw that #7557 is related |
alice-i-cecile
added
A-UI
alice-i-cecile
approved these changes
Aug 30, 2023
Member
|
If only we had constant float arithmetic :( One day, maybe. |
Contributor
Author
So true. I feel like so many crates would benefit greatly. :( |
ickshonpe
approved these changes
Aug 30, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective The two functions [`Urect::height`](https://docs.rs/bevy_math/latest/bevy_math/struct.URect.html#method.height), [`Urect::width`](https://docs.rs/bevy_math/latest/bevy_math/struct.URect.html#method.width) are currently not const. Since the methods are very unlikely to change (ever) and are useful to be const for some games, they should be. Co-authored-by: Emi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The two functions
Urect::height,Urect::widthare currently not const.
Since the methods are very unlikely to change (ever) and are useful to be const for some games, they should be.