Add a method to compute a bounding box enclosing a set of points#9630
Merged
alice-i-cecile merged 8 commits intobevyengine:mainfrom Aug 31, 2023
Merged
Add a method to compute a bounding box enclosing a set of points#9630alice-i-cecile merged 8 commits intobevyengine:mainfrom
alice-i-cecile merged 8 commits intobevyengine:mainfrom
Conversation
tguichaoua
suggested changes
Aug 29, 2023
Co-authored-by: Tristan Guichaoua <[email protected]>
alice-i-cecile
added
C-Usability
alice-i-cecile
requested changes
Aug 29, 2023
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Useful method, but this should have a moderately robust set of tests.
JMS55
reviewed
Aug 30, 2023
Contributor
|
This is implemented on Mesh bevy/crates/bevy_render/src/mesh/mesh/mod.rs Line 465 in fb094ea |
Member
Author
|
I've rewritten the |
alice-i-cecile
approved these changes
Aug 30, 2023
mockersf
approved these changes
Aug 30, 2023
mockersf
added
the
S-Ready-For-Final-Review
43 tasks
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
…yengine#9630) # Objective Make it easier to create bounding boxes in user code by providing a constructor that computes a box surrounding an arbitrary number of points. ## Solution Add `Aabb::enclosing`, which accepts iterators, slices, or arrays. --------- Co-authored-by: Tristan Guichaoua <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Make it easier to create bounding boxes in user code by providing a constructor that computes a box surrounding an arbitrary number of points.
Solution
Add
Aabb::enclosing, which accepts iterators, slices, or arrays.