Fix gamepad viewer being marked as a non-wasm example#9399
Merged
mockersf merged 1 commit intobevyengine:mainfrom Aug 9, 2023
Merged
Fix gamepad viewer being marked as a non-wasm example#9399mockersf merged 1 commit intobevyengine:mainfrom
mockersf merged 1 commit intobevyengine:mainfrom
Conversation
paul-hansen
approved these changes
Aug 9, 2023
Contributor
There was a problem hiding this comment.
Looks good to me!
Just for good measure I tested the example locally using wasm/webgpu and wasm/webgl2. I used an xbox one controller and a ps5 controller. Allworked as expected. Triggers still only report 0 or 1 (no in-between values) but that was happening on bevy 0.9 as well so I'll open a separate issue for that. Looks like there's already an upstream issue for this here: https://gitlab.com/gilrs-project/gilrs/-/issues/121
mockersf
added
C-Examples
mockersf
approved these changes
Aug 9, 2023
mockersf
added
the
S-Ready-For-Final-Review
cart
pushed a commit
that referenced
this pull request
Aug 10, 2023
# Objective This example stopped being built for the website after the example-building was reworked in (bevyengine/bevy-website#720 + #9168). This seems to have just been a mistake when defining this particular example's metadata. See bevyengine/bevy-website#726 ## Solution Update its metadata to indicate that it works with wasm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This example stopped being built for the website after the example-building was reworked in (bevyengine/bevy-website#720 + #9168).
This seems to have just been a mistake when defining this particular example's metadata.
See bevyengine/bevy-website#726
Solution
Update its metadata to indicate that it works with wasm.