Skip to content

example showcase - pagination and can build for WebGL2#9168

Merged
cart merged 3 commits intobevyengine:mainfrom
mockersf:example-showcase-improvements
Jul 17, 2023
Merged

example showcase - pagination and can build for WebGL2#9168
cart merged 3 commits intobevyengine:mainfrom
mockersf:example-showcase-improvements

Conversation

@mockersf
Copy link
Copy Markdown
Member

@mockersf mockersf commented Jul 15, 2023

Objective

  • Building all examples at once in CI takes too long
  • Tool can only build for WebGPU

Solution

  • Add pagination to commands
  • Add option to build examples for WebGL2
  • Add option to build Zola files for WebGL2

@cart cart added this pull request to the merge queue Jul 17, 2023
Merged via the queue into bevyengine:main with commit ff89968 Jul 17, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jul 18, 2023
# Objective

- in #9168 I did some change to the showcase script, introducing the
notion of web api and setting the default Web API to webgl2
- that script was actually only called for webgpu example, so that
should have been the default value
github-merge-queue bot pushed a commit that referenced this pull request Aug 9, 2023
# Objective

This example stopped being built for the website after the
example-building was reworked in
(bevyengine/bevy-website#720 + #9168).

This seems to have just been a mistake when defining this particular
example's metadata.

See bevyengine/bevy-website#726

## Solution

Update its metadata to indicate that it works with wasm.
cart pushed a commit that referenced this pull request Aug 10, 2023
# Objective

This example stopped being built for the website after the
example-building was reworked in
(bevyengine/bevy-website#720 + #9168).

This seems to have just been a mistake when defining this particular
example's metadata.

See bevyengine/bevy-website#726

## Solution

Update its metadata to indicate that it works with wasm.
@cart cart mentioned this pull request Oct 13, 2023
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants