example showcase - pagination and can build for WebGL2#9168
Merged
cart merged 3 commits intobevyengine:mainfrom Jul 17, 2023
Merged
example showcase - pagination and can build for WebGL2#9168cart merged 3 commits intobevyengine:mainfrom
cart merged 3 commits intobevyengine:mainfrom
Conversation
cart
approved these changes
Jul 17, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
# Objective - in #9168 I did some change to the showcase script, introducing the notion of web api and setting the default Web API to webgl2 - that script was actually only called for webgpu example, so that should have been the default value
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
# Objective This example stopped being built for the website after the example-building was reworked in (bevyengine/bevy-website#720 + #9168). This seems to have just been a mistake when defining this particular example's metadata. See bevyengine/bevy-website#726 ## Solution Update its metadata to indicate that it works with wasm.
cart
pushed a commit
that referenced
this pull request
Aug 10, 2023
# Objective This example stopped being built for the website after the example-building was reworked in (bevyengine/bevy-website#720 + #9168). This seems to have just been a mistake when defining this particular example's metadata. See bevyengine/bevy-website#726 ## Solution Update its metadata to indicate that it works with wasm.
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution