fix clippy::default_constructed_unit_structs and trybuild errors#9144
Merged
cart merged 3 commits intobevyengine:mainfrom Jul 13, 2023
Merged
Conversation
Member
|
could you also fix the |
mockersf
added
the
C-Code-Quality
Contributor
Author
I'm not available for the next hours. It would be faster to do it in another PR. |
cart
changed the title
clippy::default_constructed_unit_structsclippy::default_constructed_unit_structs and trybuild errors
salixsalicaceae
pushed a commit
to fslabs/bevy
that referenced
this pull request
Mar 26, 2026
…evyengine#9144) # Objective With Rust `1.71.0` ([released a few minutes ago](https://github.com/rust-lang/rust/releases/tag/1.71.0)), clippy introduced a new lint ([`default_constructed_unit_structs`](https://rust-lang.github.io/rust-clippy/master/index.html#/default_constructed_unit_structs)) wich prevent calling `default()` on unit structs (e.g. `PhantomData::default()`). ## Solution Apply the lint suggestion. --------- Co-authored-by: Carter Anderson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
With Rust
1.71.0(released a few minutes ago), clippy introduced a new lint (default_constructed_unit_structs) wich prevent callingdefault()on unit structs (e.g.PhantomData::default()).Solution
Apply the lint suggestion.