Fix not calling App::finish and App::cleanup in ScheduleRunnerPlugin#9054
Merged
cart merged 1 commit intobevyengine:mainfrom Jul 9, 2023
Merged
Fix not calling App::finish and App::cleanup in ScheduleRunnerPlugin#9054cart merged 1 commit intobevyengine:mainfrom
App::finish and App::cleanup in ScheduleRunnerPlugin#9054cart merged 1 commit intobevyengine:mainfrom
Conversation
mockersf
approved these changes
Jul 8, 2023
mockersf
added
the
S-Ready-For-Final-Review
cart
approved these changes
Jul 9, 2023
B-head
added a commit
to B-head/bevy
that referenced
this pull request
Jul 9, 2023
…RunnerPlugin` (bevyengine#9054)" This reverts commit f213c14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is mutually exclusive with #9066.
Objective
Complete the initialization of the plugin in
ScheduleRunnerPlugin.Solution
Wait for asynchronous tasks to complete, then
App::finishandApp::cleanupin the runner function.