Skip to content

Remove reference to base sets#9032

Merged
mockersf merged 1 commit intobevyengine:mainfrom
jnhyatt:base-set-fix
Jul 3, 2023
Merged

Remove reference to base sets#9032
mockersf merged 1 commit intobevyengine:mainfrom
jnhyatt:base-set-fix

Conversation

@jnhyatt
Copy link
Copy Markdown
Contributor

@jnhyatt jnhyatt commented Jul 3, 2023

Objective

  • Remove all references to base sets following schedule-first rework

Solution

  • Remove last references to base sets in GraphInfo

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 3, 2023

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added this to the 0.11 milestone Jul 3, 2023
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events labels Jul 3, 2023
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide and removed C-Docs An addition or correction to our documentation labels Jul 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 3, 2023

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@mockersf mockersf removed the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Jul 3, 2023
@mockersf mockersf added this pull request to the merge queue Jul 3, 2023
Merged via the queue into bevyengine:main with commit 01eb1bf Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants