Run update_previous_view_projections in PreUpdate schedule#9024
Merged
mockersf merged 1 commit intobevyengine:mainfrom Jul 5, 2023
Merged
Run update_previous_view_projections in PreUpdate schedule#9024mockersf merged 1 commit intobevyengine:mainfrom
update_previous_view_projections in PreUpdate schedule#9024mockersf merged 1 commit intobevyengine:mainfrom
Conversation
JMS55
approved these changes
Jul 2, 2023
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Jul 4, 2023
alice-i-cecile
added
M-Migration-Guide
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
Contributor
|
@alice-i-cecile this is not a breaking change - this code wasn't in bevy 0.10 before. |
mockersf
approved these changes
Jul 5, 2023
mockersf
removed
the
M-Migration-Guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Since a camera's view and projection matrices are modified during
PostUpdateincamera_systemandpropagate_transforms, it is fine to moveupdate_previous_view_projectionsfromUpdatetoPreUpdate.Doing so adds consistence with
update_mesh_previous_global_transformsand allows systems inUpdateto usePreviousViewProjectioncorrectly without explicit ordering.