Skip to content

Derive Eq, PartialEq for Tick#9020

Merged
mockersf merged 1 commit intobevyengine:mainfrom
chrisjuchem:juchem/tick_eq
Jul 4, 2023
Merged

Derive Eq, PartialEq for Tick#9020
mockersf merged 1 commit intobevyengine:mainfrom
chrisjuchem:juchem/tick_eq

Conversation

@chrisjuchem
Copy link
Copy Markdown
Contributor

@chrisjuchem chrisjuchem commented Jul 1, 2023

Objective

  • Remove need to call .get() on two ticks to compare them for equality.

Solution

  • Derive Eq and PartialEq.

Changelog

Tick now implements Eq and PartialEq

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 4, 2023
@mockersf mockersf added this pull request to the merge queue Jul 4, 2023
Merged via the queue into bevyengine:main with commit ca3068a Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf mockersf approved these changes

+1 more reviewer

@B-Reif B-Reif B-Reif approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisjuchem @alice-i-cecile @mockersf @B-Reif