Skip to content

Bump accesskit and accesskit_winit.#8655

Merged
cart merged 1 commit intobevyengine:mainfrom
ndarilek:bump-accesskit
Jul 7, 2023
Merged

Bump accesskit and accesskit_winit.#8655
cart merged 1 commit intobevyengine:mainfrom
ndarilek:bump-accesskit

Conversation

@ndarilek
Copy link
Copy Markdown
Contributor

@ndarilek ndarilek commented May 22, 2023

Objective

accesskit and accesskit_winit need to be upgraded.

Solution

Upgrade accesskit and accesskit_winit.

Changelog

Changed

  • Upgrade accesskit to v0.11.
  • Upgrade accesskit_winit to v0.14.

@james7132 james7132 added C-Dependencies A change to the crates that Bevy depends on A-Accessibility A problem that prevents users with disabilities from using Bevy labels May 22, 2023
@mockersf
Copy link
Copy Markdown
Member

mockersf commented May 22, 2023 •
edited
Loading

it seems accesskit_winit can't compile on linux without default features, it needs either async-io or tokio enabled...
but the way they're defined means accesskit_unix would build on all platforms

@mockersf mockersf mentioned this pull request May 29, 2023
Closed
@mockersf mockersf mentioned this pull request Jun 14, 2023
Closed
@ndarilek
Copy link
Copy Markdown
Contributor Author

ndarilek commented Jun 17, 2023

Hoping this is fixed now. Sorry it took a while to get to--been a busy last few weeks.

@ndarilek
Copy link
Copy Markdown
Contributor Author

ndarilek commented Jun 28, 2023

Would anyone mind telling me what the failing checks are here? I'd like to see this in 0.11 but Actions' log viewer continues to be an a11y hot mess and I didn't think a dependency bump would cause these.

Thanks.

@cart
Copy link
Copy Markdown
Member

cart commented Jul 7, 2023

Here are the errors:

error: Either "async-io" (default) or "tokio" must be enabled.
  --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus-3.10.0/src/lib.rs:32:5
   |
32 |     compile_error!("Either \"async-io\" (default) or \"tokio\" must be enabled.");
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

And then a bunch of "unresolved import" errors like:

error[E0432]: unresolved import `async_lock`
 --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/zbus-3.10.0/src/abstractions/async_lock.rs:2:16
  |
2 | pub(crate) use async_lock::{Mutex, RwLock, RwLockReadGuard, RwLockWriteGuard};
  |                ^^^^^^^^^^ help: a similar path exists: `crate::async_lock`
  |
  = note: `use` statements changed in Rust 2018; read more at <https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html>

I suspect the import errors would be resolved if we fixed the first "please enable a feature" error.

@cart cart added this to the 0.11 milestone Jul 7, 2023
@ndarilek
Copy link
Copy Markdown
Contributor Author

ndarilek commented Jul 7, 2023

Oh ugh, fixed this on a different branch and thought I'd pushed it to this one. Sorry about that, I guess my questions were answered earlier and I didn't realize they were still relevant.

Anyhow, hope this fixes it.

@cart cart added this pull request to the merge queue Jul 7, 2023
Merged via the queue into bevyengine:main with commit 95ade6d Jul 7, 2023
@artursapek artursapek mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Accessibility A problem that prevents users with disabilities from using Bevy C-Dependencies A change to the crates that Bevy depends on

Projects

None yet

Milestone

0.11

Development

Successfully merging this pull request may close these issues.

4 participants

@ndarilek @mockersf @cart @james7132