ecs: ergonomic query.iter(), remove locks, add QuerySets#741
Merged
cart merged 1 commit intobevyengine:masterfrom Oct 30, 2020
Merged
ecs: ergonomic query.iter(), remove locks, add QuerySets#741cart merged 1 commit intobevyengine:masterfrom
cart merged 1 commit intobevyengine:masterfrom
Conversation
Member
Author
|
benchmark results: (any omitted benchmarks from ecs_bench_suite had no significant changes) The most interesting outcomes:
|
a7e7bf1 to
9a08483
Compare
memoryruins
approved these changes
Oct 28, 2020
Member
|
The docs on ParallelExecutor need to be updated to talk about the parallelism change I think |
Member
Author
|
done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
query.iter()is now a real iterator!query.entity()is now "flat".query.iter()andquery.entity()are exactly as fast as their World counterparts (which became lock-less in the last bevy_ecs update). This is because ...QuerySettype. This provides lifetime safety that prevents illegal query accesses:query.par_iter()andquery.par_iter_mut()were added to the top level Query typeaccess() -> Option<Access>,borrow(), andrelease()methods onFetchwith a single, much simpler and flexibleaccess() -> QueryAccessUnfilteredFetchtrait)QueryIterto be much simpler. This results in much more stable and predictable optimizations. This should prevent certain permutations of systems (and sets of systems) from falling off the "fast/optimized path", as called out here: Establishing More Reliable Benchmarks #655 (comment)