Skip to content

Prefixless bevy_gpu split#7111

Closed
kurtkuehnert wants to merge 4 commits intobevyengine:mainfrom
kurtkuehnert:prefixless_bevy_gpu_split
Closed

Prefixless bevy_gpu split#7111
kurtkuehnert wants to merge 4 commits intobevyengine:mainfrom
kurtkuehnert:prefixless_bevy_gpu_split

Conversation

@kurtkuehnert
Copy link
Copy Markdown
Contributor

Objective

…ce, Context} to Gpu{Device, Queue, Adapter, AdapterInfo, Instance, Context}

renamed variable names render_{device, queue, adapter, adapter_info, instance, context} to gpu_{device, queue, adapter, adapter_info, instance, context}

renamed occurrences of the variable name `device` that refer to a `GPUDevice` to `gpu_device`

renamed occurrences of the variable name `queue` that refer to a `GPUQueue` to `gpu_queue`

type aliased GpuCommandEncoder
renamed GpuContext::command_encoder to GpuContext::gpu_command_encoder
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change X-Needs-SME This type of work requires an SME to approve it. labels Jan 6, 2023
@jnhyatt
Copy link
Copy Markdown
Contributor

jnhyatt commented Oct 26, 2023

What if we based this on #10272 instead of #7109? Per @alice-i-cecile 's comment, we could ditch all the Bevy re-exports and just re-export wgpu. bevy_gpu would be a sensible place for that re-export anyway.

EDIT - To be clear, #10272 would need a follow up, it doesn't remove Render* types

@alice-i-cecile alice-i-cecile added X-Contentious There are nontrivial implications that should be thought through and removed X-Needs-SME This type of work requires an SME to approve it. labels Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change X-Contentious There are nontrivial implications that should be thought through

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants