[Merged by Bors] - Fix Sparse Change Detection#6896
Closed
james7132 wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Fix Sparse Change Detection#6896james7132 wants to merge 1 commit intobevyengine:mainfrom
james7132 wants to merge 1 commit intobevyengine:mainfrom
Conversation
james7132
added
C-Bug
HoNile
approved these changes
Dec 9, 2022
inodentry
approved these changes
Dec 9, 2022
mockersf
approved these changes
Dec 9, 2022
mockersf
added
the
S-Ready-For-Final-Review
joseph-gio
approved these changes
Dec 10, 2022
Member
|
Bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 10, 2022
# Objective #6547 accidentally broke change detection for SparseSet components by using `Ticks::from_tick_cells` with the wrong argument order. ## Solution Use the right argument order. Add a regression test.
Contributor
bors
bot
changed the title
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective bevyengine#6547 accidentally broke change detection for SparseSet components by using `Ticks::from_tick_cells` with the wrong argument order. ## Solution Use the right argument order. Add a regression test.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective bevyengine#6547 accidentally broke change detection for SparseSet components by using `Ticks::from_tick_cells` with the wrong argument order. ## Solution Use the right argument order. Add a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
#6547 accidentally broke change detection for SparseSet components by using
Ticks::from_tick_cellswith the wrong argument order.Solution
Use the right argument order. Add a regression test.