Skip to content

Fix bloom alpha handling#6636

Closed
JMS55 wants to merge 1 commit intobevyengine:mainfrom
JMS55:bloom-transparent-fix
Closed

Fix bloom alpha handling#6636
JMS55 wants to merge 1 commit intobevyengine:mainfrom
JMS55:bloom-transparent-fix

Conversation

@JMS55
Copy link
Copy Markdown
Contributor

@JMS55 JMS55 commented Nov 15, 2022

Fixes #6634.

@james7132 james7132 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Nov 15, 2022
@james7132 james7132 added this to the 0.9.1 milestone Nov 15, 2022
@JMS55
Copy link
Copy Markdown
Contributor Author

JMS55 commented Nov 15, 2022

After some discussion, this probably needs further thought. I probably shouldn't be using the previous alpha when downsampling or upsampling, it should probably only be during the final step. And we might want to do some kind of max of the current and new alpha, so that bloom shows up in transparent areas. Copying the original alpha would always force those pixels to be transparent.

@JMS55
Copy link
Copy Markdown
Contributor Author

JMS55 commented Nov 17, 2022

Closing as I am revamping bloom in a future PR.

@JMS55 JMS55 closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bloom results in transparency across frame

2 participants