[Merged by Bors] - Adding Debug implementations for App, Stage, Schedule, Query, QueryState, etc.#6214
Closed
targrub wants to merge 11 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Adding Debug implementations for App, Stage, Schedule, Query, QueryState, etc.#6214targrub wants to merge 11 commits intobevyengine:mainfrom
targrub wants to merge 11 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
added
A-ECS
Added a copy of the Debug of App for SubApps. Removed newline in SystemContainer Debug. Added more Debug info for Systems with run criteria.
Contributor
Author
|
There is something odd about the output for CoreStage::Last: Stage Some(SystemStage: { Note the " |
Member
|
harudagondi
approved these changes
Oct 10, 2022
alice-i-cecile
approved these changes
Oct 10, 2022
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
I'm happy with this now. Great work.
bors r+
alice-i-cecile
added
the
S-Ready-For-Final-Review
bors bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
…ate, etc. (#6214) # Objective - Adding Debug implementations for App, Stage, Schedule, Query, QueryState. - Fixes #1130. ## Solution - Implemented std::fmt::Debug for a number of structures. --- ## Changelog Also added Debug implementations for ParallelSystemExecutor, SingleThreadedExecutor, various RunCriteria structures, SystemContainer, and SystemDescriptor. Opinions are sure to differ as to what information to provide in a Debug implementation. Best guess was taken for this initial version for these structures. Co-authored-by: targrub <[email protected]>
Contributor
|
Build failed: |
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
…ate, etc. (#6214) # Objective - Adding Debug implementations for App, Stage, Schedule, Query, QueryState. - Fixes #1130. ## Solution - Implemented std::fmt::Debug for a number of structures. --- ## Changelog Also added Debug implementations for ParallelSystemExecutor, SingleThreadedExecutor, various RunCriteria structures, SystemContainer, and SystemDescriptor. Opinions are sure to differ as to what information to provide in a Debug implementation. Best guess was taken for this initial version for these structures. Co-authored-by: targrub <[email protected]>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 19, 2022
…ate, etc. (bevyengine#6214) # Objective - Adding Debug implementations for App, Stage, Schedule, Query, QueryState. - Fixes bevyengine#1130. ## Solution - Implemented std::fmt::Debug for a number of structures. --- ## Changelog Also added Debug implementations for ParallelSystemExecutor, SingleThreadedExecutor, various RunCriteria structures, SystemContainer, and SystemDescriptor. Opinions are sure to differ as to what information to provide in a Debug implementation. Best guess was taken for this initial version for these structures. Co-authored-by: targrub <[email protected]>
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
…ate, etc. (bevyengine#6214) # Objective - Adding Debug implementations for App, Stage, Schedule, Query, QueryState. - Fixes bevyengine#1130. ## Solution - Implemented std::fmt::Debug for a number of structures. --- ## Changelog Also added Debug implementations for ParallelSystemExecutor, SingleThreadedExecutor, various RunCriteria structures, SystemContainer, and SystemDescriptor. Opinions are sure to differ as to what information to provide in a Debug implementation. Best guess was taken for this initial version for these structures. Co-authored-by: targrub <[email protected]>
Pietrek14
pushed a commit
to Pietrek14/bevy
that referenced
this pull request
Dec 17, 2022
…ate, etc. (bevyengine#6214) # Objective - Adding Debug implementations for App, Stage, Schedule, Query, QueryState. - Fixes bevyengine#1130. ## Solution - Implemented std::fmt::Debug for a number of structures. --- ## Changelog Also added Debug implementations for ParallelSystemExecutor, SingleThreadedExecutor, various RunCriteria structures, SystemContainer, and SystemDescriptor. Opinions are sure to differ as to what information to provide in a Debug implementation. Best guess was taken for this initial version for these structures. Co-authored-by: targrub <[email protected]>
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…ate, etc. (bevyengine#6214) # Objective - Adding Debug implementations for App, Stage, Schedule, Query, QueryState. - Fixes bevyengine#1130. ## Solution - Implemented std::fmt::Debug for a number of structures. --- ## Changelog Also added Debug implementations for ParallelSystemExecutor, SingleThreadedExecutor, various RunCriteria structures, SystemContainer, and SystemDescriptor. Opinions are sure to differ as to what information to provide in a Debug implementation. Best guess was taken for this initial version for these structures. Co-authored-by: targrub <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Changelog
Also added Debug implementations for ParallelSystemExecutor, SingleThreadedExecutor, various RunCriteria structures, SystemContainer, and SystemDescriptor.
Opinions are sure to differ as to what information to provide in a Debug implementation. Best guess was taken for this initial version for these structures.