[Merged by Bors] - Remove unused DepthCalculation enum#5684
Closed
contagnas wants to merge 1 commit intobevyengine:mainfrom
contagnas:remove-DepthCalculation-enum
Closed
[Merged by Bors] - Remove unused DepthCalculation enum#5684contagnas wants to merge 1 commit intobevyengine:mainfrom contagnas:remove-DepthCalculation-enum
contagnas wants to merge 1 commit intobevyengine:mainfrom
contagnas:remove-DepthCalculation-enum
Conversation
alice-i-cecile
added
A-Rendering
alice-i-cecile
approved these changes
Aug 14, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
rparrett
reviewed
Aug 14, 2022
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2022
# Objective Remove unused `enum DepthCalculation` and its usages. This was used to compute visible entities in the [old renderer](https://github.com/bevyengine/bevy/blob/db665b96c07084f081b0c9ab367e67297fe35132/crates/bevy_render/src/camera/visible_entities.rs), but is now unused. ## Solution `sed 's/DepthCalculation//g'` --- ## Changelog ### Changed Removed `bevy_render::camera::DepthCalculation`. ## Migration Guide Remove references to `bevy_render::camera::DepthCalculation`, such as `use bevy_render::camera::DepthCalculation`. Remove `depth_calculation` fields from Projections.
Contributor
|
Build failed: |
Remove comment from depth_calculation Co-authored-by: Rob Parrett <[email protected]> cargo fmt
mockersf
approved these changes
Aug 14, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 14, 2022
# Objective Remove unused `enum DepthCalculation` and its usages. This was used to compute visible entities in the [old renderer](https://github.com/bevyengine/bevy/blob/db665b96c07084f081b0c9ab367e67297fe35132/crates/bevy_render/src/camera/visible_entities.rs), but is now unused. ## Solution `sed 's/DepthCalculation//g'` --- ## Changelog ### Changed Removed `bevy_render::camera::DepthCalculation`. ## Migration Guide Remove references to `bevy_render::camera::DepthCalculation`, such as `use bevy_render::camera::DepthCalculation`. Remove `depth_calculation` fields from Projections.
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
maccesch
pushed a commit
to Synphonyte/bevy
that referenced
this pull request
Sep 28, 2022
# Objective Remove unused `enum DepthCalculation` and its usages. This was used to compute visible entities in the [old renderer](https://github.com/bevyengine/bevy/blob/db665b96c07084f081b0c9ab367e67297fe35132/crates/bevy_render/src/camera/visible_entities.rs), but is now unused. ## Solution `sed 's/DepthCalculation//g'` --- ## Changelog ### Changed Removed `bevy_render::camera::DepthCalculation`. ## Migration Guide Remove references to `bevy_render::camera::DepthCalculation`, such as `use bevy_render::camera::DepthCalculation`. Remove `depth_calculation` fields from Projections.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective Remove unused `enum DepthCalculation` and its usages. This was used to compute visible entities in the [old renderer](https://github.com/bevyengine/bevy/blob/db665b96c07084f081b0c9ab367e67297fe35132/crates/bevy_render/src/camera/visible_entities.rs), but is now unused. ## Solution `sed 's/DepthCalculation//g'` --- ## Changelog ### Changed Removed `bevy_render::camera::DepthCalculation`. ## Migration Guide Remove references to `bevy_render::camera::DepthCalculation`, such as `use bevy_render::camera::DepthCalculation`. Remove `depth_calculation` fields from Projections.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Remove unused `enum DepthCalculation` and its usages. This was used to compute visible entities in the [old renderer](https://github.com/bevyengine/bevy/blob/db665b96c07084f081b0c9ab367e67297fe35132/crates/bevy_render/src/camera/visible_entities.rs), but is now unused. ## Solution `sed 's/DepthCalculation//g'` --- ## Changelog ### Changed Removed `bevy_render::camera::DepthCalculation`. ## Migration Guide Remove references to `bevy_render::camera::DepthCalculation`, such as `use bevy_render::camera::DepthCalculation`. Remove `depth_calculation` fields from Projections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Remove unused
enum DepthCalculationand its usages. This was used to compute visible entities in the old renderer, but is now unused.Solution
sed 's/DepthCalculation//g'Changelog
Changed
Removed
bevy_render::camera::DepthCalculation.Migration Guide
Remove references to
bevy_render::camera::DepthCalculation, such asuse bevy_render::camera::DepthCalculation. Removedepth_calculationfields from Projections.