[Merged by Bors] - Wireframe Rendering Pipeline#562
Closed
PixelDust22 wants to merge 8 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Wireframe Rendering Pipeline#562PixelDust22 wants to merge 8 commits intobevyengine:mainfrom
PixelDust22 wants to merge 8 commits intobevyengine:mainfrom
Conversation
memoryruins
added
C-Feature
Member
Discord discussion of this issue. |
Contributor
|
No longer blocked! |
Contributor
Author
will start working on this as soon as I get some time! |
Contributor
Author
PixelDust22
force-pushed
the
wireframe
branch
from
334ecd2 to
ae27107
Compare
alice-i-cecile
added
the
S-Ready-For-Final-Review
Contributor
Author
cart
reviewed
Mar 3, 2021
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2021
This PR implements wireframe rendering. Usage: This is now ready as soon as #1401 gets merged. Usage: ```rust app .insert_resource(WgpuOptions { name: Some("3d_scene"), features: WgpuFeatures::NON_FILL_POLYGON_MODE, ..Default::default() }) // To enable the NON_FILL_POLYGON_MODE feature .add_plugin(WireframePlugin) .run(); ``` Now we just need to add the Wireframe component on an entity, and it'll draw. its wireframe. We can also enable wireframe drawing globally by setting the global property in the `WireframeConfig` resource to `true`. Co-authored-by: Zhixing Zhang <[email protected]>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
This was referenced Mar 6, 2021
bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2021
#562 added a new Example, but forgot to also document it in the examples readme.
bors bot
pushed a commit
that referenced
this pull request
Dec 10, 2021
Updates the wireframe rendering initialliy implemented in #562 to the new renderer. It lives in `bevy_pbr2` instead of `bevy_render2` because that way it can reuse the `MeshPipeline`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements wireframe rendering.
Usage:
This is now ready as soon as #1401 gets merged.
Usage:
app .insert_resource(WgpuOptions { name: Some("3d_scene"), features: WgpuFeatures::NON_FILL_POLYGON_MODE, ..Default::default() }) // To enable the NON_FILL_POLYGON_MODE feature .add_plugin(WireframePlugin) .run();Now we just need to add the Wireframe component on an entity, and it'll draw. its wireframe.
We can also enable wireframe drawing globally by setting the global property in the
WireframeConfigresource totrue.