[Merged by Bors] - Separate PBR and tone mapping into 2 functions#5078
Closed
cryscan wants to merge 1 commit intobevyengine:mainfrom
cryscan:main
Closed
[Merged by Bors] - Separate PBR and tone mapping into 2 functions#5078cryscan wants to merge 1 commit intobevyengine:mainfrom cryscan:main
cryscan wants to merge 1 commit intobevyengine:mainfrom
cryscan:main
Conversation
superdump
added
C-Feature
Contributor
|
I hadn't done this as tonemapping is going to be separated out fully shortly and so it would be done as part of that. I think @cart was looking into that? |
Contributor
|
@superdump I think this would be useful in the meantime. It would allow for people to implement their own tonemapping, or bypass it completely. (which I need to do for creating environment maps) |
DGriffin91
approved these changes
Jun 24, 2022
alice-i-cecile
removed
the
C-Feature
superdump
approved these changes
Jun 25, 2022
Contributor
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 26, 2022
# Objective - Allow custom shaders to reuse the HDR results of PBR. ## Solution - Separate `pbr()` and `tone_mapping()` into 2 functions in `pbr_functions.wgsl`.
Contributor
bors
bot
changed the title
inodentry
pushed a commit
to IyesGames/bevy
that referenced
this pull request
Aug 8, 2022
# Objective - Allow custom shaders to reuse the HDR results of PBR. ## Solution - Separate `pbr()` and `tone_mapping()` into 2 functions in `pbr_functions.wgsl`.
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Oct 28, 2022
# Objective - Allow custom shaders to reuse the HDR results of PBR. ## Solution - Separate `pbr()` and `tone_mapping()` into 2 functions in `pbr_functions.wgsl`.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Allow custom shaders to reuse the HDR results of PBR. ## Solution - Separate `pbr()` and `tone_mapping()` into 2 functions in `pbr_functions.wgsl`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
pbr()andtone_mapping()into 2 functions inpbr_functions.wgsl.