Skip to content

[Merged by Bors] - Document bevy_math#4591

Closed
ghost wants to merge 2 commits intomainfrom
unknown repository
Closed

[Merged by Bors] - Document bevy_math#4591
ghost wants to merge 2 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 25, 2022

Objective

Solution

  • Document the bevy_math crate and add the #![warn(missing_docs)] lint.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 25, 2022
@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Math Fundamental domain-agnostic mathematical operations and removed S-Needs-Triage This issue needs to be labelled labels Apr 25, 2022
@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Apr 25, 2022

Good! I'm going to call this one "trivial".

@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Apr 25, 2022

bors r+

@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Apr 25, 2022

bors r-

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Apr 25, 2022

Canceled.

@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Apr 25, 2022

Going to wait a bit to let folks double-check for nits :)

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 25, 2022
@alice-i-cecile alice-i-cecile mentioned this pull request Apr 25, 2022
Open
45 tasks
tim-blackbird
tim-blackbird reviewed Apr 25, 2022
View reviewed changes
@alice-i-cecile
Copy link
Copy Markdown
Member

alice-i-cecile commented Apr 26, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 26, 2022
Document bevy_math (#4591)
18b2726 
# Objective

- Part of #3492

## Solution

- Document the `bevy_math` crate and add the `#![warn(missing_docs)]` lint.
@bors
Copy link
Copy Markdown
Contributor

bors bot commented Apr 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Document bevy_math [Merged by Bors] - Document bevy_math Apr 26, 2022
@bors bors bot closed this Apr 26, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
@exjam
Document bevy_math (bevyengine#4591)
4af1866 
# Objective

- Part of bevyengine#3492

## Solution

- Document the `bevy_math` crate and add the `#![warn(missing_docs)]` lint.
@ghost ghost deleted the document_bevy_math branch August 7, 2022 08:27
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@ItsDoot
Document bevy_math (bevyengine#4591)
d40d222 
# Objective

- Part of bevyengine#3492

## Solution

- Document the `bevy_math` crate and add the `#![warn(missing_docs)]` lint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Math Fundamental domain-agnostic mathematical operations C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alice-i-cecile @tim-blackbird