[Merged by Bors] - Make WinitWindows non send#4027
Closed
aevyrie wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - Make WinitWindows non send#4027aevyrie wants to merge 1 commit intobevyengine:mainfrom
WinitWindows non send#4027aevyrie wants to merge 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Feb 23, 2022
Member
|
Checks out, and the comments are very helpful. |
alice-i-cecile
added
A-Windowing
This was referenced Feb 23, 2022
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2022
# Objective - Fixes #4010, as well as any similar issues in this class. - Winit functions used outside of the main thread can cause the application to unexpectedly hang. ## Solution - Make the `WinitWindows` resource `!Send`. - This ensures that any systems that use `WinitWindows` must either be exclusive (run on the main thread), or the resource is explicitly marked with the `NonSend` parameter in user systems.
Contributor
bors
bot
changed the title
WinitWindows non sendWinitWindows non send
kurtkuehnert
pushed a commit
to kurtkuehnert/bevy
that referenced
this pull request
Mar 6, 2022
# Objective - Fixes bevyengine#4010, as well as any similar issues in this class. - Winit functions used outside of the main thread can cause the application to unexpectedly hang. ## Solution - Make the `WinitWindows` resource `!Send`. - This ensures that any systems that use `WinitWindows` must either be exclusive (run on the main thread), or the resource is explicitly marked with the `NonSend` parameter in user systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
WinitWindowsresource!Send.WinitWindowsmust either be exclusive (run on the main thread), or the resource is explicitly marked with theNonSendparameter in user systems.