[Merged by Bors] - Enable Msaa for webgl by default#3489
Closed
mockersf wants to merge 2 commits intobevyengine:mainfrom
Closed
[Merged by Bors] - Enable Msaa for webgl by default#3489mockersf wants to merge 2 commits intobevyengine:mainfrom
mockersf wants to merge 2 commits intobevyengine:mainfrom
Conversation
mockersf
added
A-Rendering
jakobhellermann
approved these changes
Dec 29, 2021
Member
|
Love it! |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 29, 2021
# Objective - `Msaa` was disabled in webgl due to a bug in wgpu - Bug has been fixed (gfx-rs/wgpu#2307) and backported (gfx-rs/wgpu#2327), and updates for [`wgpu-core`](https://crates.io/crates/wgpu-core/0.12.1) and [`wgpu-hal`](https://crates.io/crates/wgpu-hal/0.12.1) have been released ## Solution - Remove custom config for `Msaa` in webgl - I also changed two options that were using the arch instead of the `webgl` feature. it shouldn't change much for webgl, but could help if someone wants to target wasm but not webgl2 Co-authored-by: François <[email protected]>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
mockersf
added a commit
to mockersf/bevy
that referenced
this pull request
Jan 1, 2022
# Objective - `Msaa` was disabled in webgl due to a bug in wgpu - Bug has been fixed (gfx-rs/wgpu#2307) and backported (gfx-rs/wgpu#2327), and updates for [`wgpu-core`](https://crates.io/crates/wgpu-core/0.12.1) and [`wgpu-hal`](https://crates.io/crates/wgpu-hal/0.12.1) have been released ## Solution - Remove custom config for `Msaa` in webgl - I also changed two options that were using the arch instead of the `webgl` feature. it shouldn't change much for webgl, but could help if someone wants to target wasm but not webgl2 Co-authored-by: François <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Msaawas disabled in webgl due to a bug in wgpuwgpu-coreandwgpu-halhave been releasedSolution
Msaain webglwebglfeature. it shouldn't change much for webgl, but could help if someone wants to target wasm but not webgl2