[Merged by Bors] - Pipelined separate shadow vertex shader#2727
Closed
superdump wants to merge 2 commits intobevyengine:pipelined-renderingfrom
Closed
[Merged by Bors] - Pipelined separate shadow vertex shader#2727superdump wants to merge 2 commits intobevyengine:pipelined-renderingfrom
superdump wants to merge 2 commits intobevyengine:pipelined-renderingfrom
Conversation
64 tasks
Member
|
Looks good to me! I expect this to conflict with the almost-done-merging #2726. |
superdump
force-pushed
the
pipelined-separate-shadow-vertex-shader
branch
from
5027e98 to
24d9d0e
Compare
Contributor
Author
Updated. |
cart
added
A-Rendering
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 25, 2021
# Objective - Avoid unnecessary work in the vertex shader of the numerous shadow passes - Have the natural order of bind groups in the pbr shader: view, material, mesh ## Solution - Separate out the vertex stage of pbr.wgsl into depth.wgsl - Remove the unnecessary calculation of uv and normal, as well as removing the unnecessary vertex inputs and outputs - Use the depth.wgsl for shadow passes - Reorder the bind groups in pbr.wgsl and PbrShaders to be 0 - view, 1 - material, 2 - mesh in decreasing order of rebind frequency
Contributor
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution