[Merged by Bors] - Add missing bytemuck feature#2625
Closed
zicklag wants to merge 1 commit intobevyengine:pipelined-renderingfrom
Closed
[Merged by Bors] - Add missing bytemuck feature#2625zicklag wants to merge 1 commit intobevyengine:pipelined-renderingfrom
zicklag wants to merge 1 commit intobevyengine:pipelined-renderingfrom
Conversation
When building Bevy with the bevy_sprite2 feature, but without the bevy_pbr2 feature, the bytemuck crate was missing the "derive" feature.
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 10, 2021
# Objective - Allow you to compile Bevy with the `bevy_sprite2` feature, but without the `bevy_pbr2` feature. - This currently fails because the `bevy_sprite2` crate does not require the `derive` feature of the `bytemuck` crate in its `Cargo.toml`, even though it is required to compile. ## Solution - Add the `derive` feature of `bytemuck` to the `bevy_sprite2` crate
Contributor
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_sprite2feature, but without thebevy_pbr2feature.bevy_sprite2crate does not require thederivefeature of thebytemuckcrate in itsCargo.toml, even though it is required to compile.Solution
derivefeature ofbytemuckto thebevy_sprite2crate