[Merged by Bors] - Port bevy_gltf to pipelined-rendering#2537
Closed
superdump wants to merge 2 commits intobevyengine:pipelined-renderingfrom
Closed
[Merged by Bors] - Port bevy_gltf to pipelined-rendering#2537superdump wants to merge 2 commits intobevyengine:pipelined-renderingfrom
superdump wants to merge 2 commits intobevyengine:pipelined-renderingfrom
Conversation
64 tasks
alice-i-cecile
added
A-Assets
cart
force-pushed
the
pipelined-rendering
branch
from
05bd717 to
955c79f
Compare
Contributor
Author
|
I did diff |
Member
|
bors r+ |
Member
|
bors r- |
Contributor
|
Canceled. |
Member
|
bors r+ |
Member
|
Haha CI demands that you add the new pipelined gltf example to the "examples" readme. |
Contributor
|
Canceled. |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 29, 2021
# Objective Port bevy_gltf to the pipelined-rendering branch. ## Solution crates/bevy_gltf has been copied and pasted into pipelined/bevy_gltf2 and modifications were made to work with the pipelined-rendering branch. Notably vertex tangents and vertex colours are not supported. Co-authored-by: Carter Anderson <[email protected]>
Contributor
|
Canceled. |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 29, 2021
# Objective Port bevy_gltf to the pipelined-rendering branch. ## Solution crates/bevy_gltf has been copied and pasted into pipelined/bevy_gltf2 and modifications were made to work with the pipelined-rendering branch. Notably vertex tangents and vertex colours are not supported. Co-authored-by: Carter Anderson <[email protected]>
Contributor
|
Timed out. |
Member
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
# Objective Port bevy_gltf to the pipelined-rendering branch. ## Solution crates/bevy_gltf has been copied and pasted into pipelined/bevy_gltf2 and modifications were made to work with the pipelined-rendering branch. Notably vertex tangents and vertex colours are not supported. Co-authored-by: Carter Anderson <[email protected]>
Contributor
|
Build failed: |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
# Objective Port bevy_gltf to the pipelined-rendering branch. ## Solution crates/bevy_gltf has been copied and pasted into pipelined/bevy_gltf2 and modifications were made to work with the pipelined-rendering branch. Notably vertex tangents and vertex colours are not supported.
Contributor
|
Build failed: |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
# Objective Port bevy_gltf to the pipelined-rendering branch. ## Solution crates/bevy_gltf has been copied and pasted into pipelined/bevy_gltf2 and modifications were made to work with the pipelined-rendering branch. Notably vertex tangents and vertex colours are not supported.
Member
|
Added the clippy fixes from |
Contributor
|
Build failed: |
Member
|
This is what I get for being lazy and not just running rustup + testing locally 😄 |
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
# Objective Port bevy_gltf to the pipelined-rendering branch. ## Solution crates/bevy_gltf has been copied and pasted into pipelined/bevy_gltf2 and modifications were made to work with the pipelined-rendering branch. Notably vertex tangents and vertex colours are not supported. Co-authored-by: Carter Anderson <[email protected]>
Contributor
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Port bevy_gltf to the pipelined-rendering branch.
Solution
crates/bevy_gltf has been copied and pasted into pipelined/bevy_gltf2 and modifications were made to work with the pipelined-rendering branch. Notably vertex tangents and vertex colours are not supported.