Add tests for processor initialization and fix a bug with initialization.#21855
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Nov 20, 2025
Merged
Add tests for processor initialization and fix a bug with initialization.#21855alice-i-cecile merged 3 commits intobevyengine:mainfrom
alice-i-cecile merged 3 commits intobevyengine:mainfrom
Conversation
andriyDev
force-pushed
the
processor-init-tests
branch
from
725ce35 to
a3fa4b3
Compare
Contributor
Author
|
CI breakage is unrelated and probably broken on main. |
andriyDev
added
A-Assets
Contributor
Author
|
CI should be fixed by #21818 |
andriyDev
force-pushed
the
processor-init-tests
branch
from
a3fa4b3 to
f76d513
Compare
kristoff3r
approved these changes
Nov 16, 2025
greeble-dev
approved these changes
Nov 16, 2025
andriyDev
added
S-Ready-For-Final-Review
beicause
pushed a commit
to beicause/bevy
that referenced
this pull request
Nov 26, 2025
…ion. (bevyengine#21855) # Objective - We have no tests on the initialization process with an existing processing state. - There was a bug (caught by these tests!) where we were deleting directories while we were iterating through them, resulting in us missing directories in some cases. ## Solution - Add two tests to ensure processor init does what we expect with existing processed assets. - Store all the empty directories in a Vec while iterating and then delete them all after we're done iterating. ## Testing - Yup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing