Allow deprecated heapless::mpmc to fix no_std builds#21818
Allow deprecated heapless::mpmc to fix no_std builds#21818alice-i-cecile merged 1 commit intobevyengine:mainfrom
heapless::mpmc to fix no_std builds#21818Conversation
cart
added
C-Bug
| target_has_atomic = "64", | ||
| target_has_atomic = "ptr" | ||
| )))] | ||
| #[allow(deprecated)] |
There was a problem hiding this comment.
You might have to allow allow_attribute
| use core::cell::Cell; | ||
|
|
||
| use bevy_tasks::{block_on, futures_lite::{pending, poll_once}}; | ||
| use bevy_tasks::{ |
There was a problem hiding this comment.
Weird unrelated change. I expect that rustfmt prevents this.
There was a problem hiding this comment.
I believe this is actually because this file wasnt rustfmt-ed for some reason.
|
the no std job is not required by CI so its failures are not blocking, and the deprecation is used there to mark a real issue. I would prefer to have the investigation in #21819 from their doc:
and
So it's not actually deprecated, but used to mark that it doesn't work as expected in some cases |
alice-i-cecile
added
S-Ready-For-Final-Review
) # Objective `heapless` just deprecated their `mpmc` module in a minor version, which broke our `no_std` builds (because we choose to break our break our builds on warnings). rust-embedded/heapless#583 https://docs.rs/heapless/latest/heapless/mpmc/index.html ## Solution Short term, fix our builds by allowing this usage of a deprecated function. However it is worth investigating: bevyengine#21819
4 participants
Objective
heaplessjust deprecated theirmpmcmodule in a minor version, which broke ourno_stdbuilds (because we choose to break our break our builds on warnings).rust-embedded/heapless#583
https://docs.rs/heapless/latest/heapless/mpmc/index.html
Solution
Short term, fix our builds by allowing this usage of a deprecated function. However it is worth investigating: #21819